From ccefa38e197cc28811394967f1aed6ed852e433d Mon Sep 17 00:00:00 2001 From: Marco Benelli Date: Fri, 14 Dec 2018 15:24:51 +0100 Subject: [PATCH] qmljs: fix a crash in the highlighter Task-number: QTCREATORBUG-21728 Change-Id: I0508d55ec8fc248833597f8e19e9aa1128f1b7ad Reviewed-by: hjk --- src/plugins/qmljseditor/qmljssemantichighlighter.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/qmljseditor/qmljssemantichighlighter.cpp b/src/plugins/qmljseditor/qmljssemantichighlighter.cpp index cca1909cb47..3541793208c 100644 --- a/src/plugins/qmljseditor/qmljssemantichighlighter.cpp +++ b/src/plugins/qmljseditor/qmljssemantichighlighter.cpp @@ -323,7 +323,7 @@ protected: bool visit(UiPublicMember *ast) override { - if (ast->typeToken.isValid()) { // TODO: ast->isValid() ? + if (ast->typeToken.isValid() && ast->memberType) { if (m_scopeChain.context()->lookupType(m_scopeChain.document().data(), QStringList(ast->memberType->name.toString()))) addUse(ast->typeToken, SemanticHighlighter::QmlTypeType); }