feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

IVersionControl: Implement topic cache in the base class

Browse Source 
Derivatives need to derive TopicCache, implement its pure virtual
functions and pass it in IVersionControl's constructor.

Change-Id: I3a904c84541fda95eee75296f86441c4bae55d79
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
Orgad Shaneh
2014-02-18 23:14:50 +02:00
committed by Orgad Shaneh
parent c68ebeed2e
commit cd48c5e513
4 changed files with 112 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

55
src/plugins/coreplugin/iversioncontrol.cpp
View File

@@ -28,7 +28,29 @@
****************************************************************************/
#include "iversioncontrol.h"
#include "vcsmanager.h"
#include <utils/qtcassert.h>
#include <QFileInfo>
/*!
* \class Core::IVersionControl::TopicCache
* \brief The TopicCache class stores a {directory -> topic} cache
*
* In order to support topic, an IVersionControl subclass needs to create
* an instance of TopicCache subclass with appropriate overrides for its
* pure virtual functions, and pass this instance to IVersionControl's constructor.
*/
/*!
* \fn Core::IVersionControl::TopicCache::trackFile(const QString &repository)
* Returns path to file that invalidates the cache when modified, for \a repository.
* e.g. for git this file is .git/HEAD
*
* \fn Core::IVersionControl::TopicCache::refreshTopic(const QString &repository)
* Returns current topic for \a repository.
*/
namespace Core {
QString IVersionControl::vcsOpenText() const
@@ -41,9 +63,14 @@ QString IVersionControl::vcsMakeWritableText() const
return QString();
}
QString IVersionControl::vcsTopic(const QString &)
QString IVersionControl::vcsTopic(const QString &topLevel)
{
return QString();
return m_topicCache ? m_topicCache->topic(topLevel) : QString();
}
IVersionControl::~IVersionControl()
{
delete m_topicCache;
}
IVersionControl::OpenSupportMode IVersionControl::openSupportMode(const QString &fileName) const
@@ -52,6 +79,30 @@ IVersionControl::OpenSupportMode IVersionControl::openSupportMode(const QString
return NoOpen;
}
IVersionControl::TopicCache::~TopicCache()
{
}
/*!
* Returns topic for repository under \a topLevel.
*
* If the cache for \a topLevel is valid, it will be used. Otherwise it will be refreshed.
*/
QString IVersionControl::TopicCache::topic(const QString &topLevel)
{
QTC_ASSERT(!topLevel.isEmpty(), return QString());
TopicData &data = m_cache[topLevel];
QString file = trackFile(topLevel);
if (file.isEmpty())
return QString();
const QDateTime lastModified = QFileInfo(file).lastModified();
if (lastModified == data.timeStamp)
return data.topic;
data.timeStamp = lastModified;
return data.topic = refreshTopic(topLevel);
}
} // namespace Core
#if defined(WITH_TESTS)