feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Fix Krazy-warnings in ClearCase-plugin.

Browse Source 
- non-const ref iterator
- values or keys iteration

Change-Id: If04abcafbeb8d5d143097ae66589b6f18bd7e28d
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Friedemann Kleint
2013-03-08 09:53:02 +01:00
parent 07ea5346bc
commit cd7fdf7a4a
3 changed files with 18 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/clearcase/clearcasesettings.cpp
View File

@@ -103,6 +103,8 @@ void ClearCaseSettings::fromSettings(QSettings *settings)
void ClearCaseSettings::toSettings(QSettings *settings) const
{
typedef QHash<QString, int>::ConstIterator FilesConstIt;
settings->beginGroup(QLatin1String(groupC));
settings->setValue(QLatin1String(commandKeyC), ccCommand);
settings->setValue(QLatin1String(autoCheckOutKeyC), autoCheckOut);
@@ -121,8 +123,9 @@ void ClearCaseSettings::toSettings(QSettings *settings) const
settings->setValue(QLatin1String(disableIndexerKeyC), disableIndexer);
settings->setValue(QLatin1String(indexOnlyVOBsC), indexOnlyVOBs);
settings->beginGroup(QLatin1String(totalFilesKeyC));
foreach (const QString &view, totalFiles.keys())
settings->setValue(view, totalFiles[view]);
const FilesConstIt fcend = totalFiles.constEnd();
for (FilesConstIt it = totalFiles.constBegin(); it != fcend; ++it)
settings->setValue(it.key(), it.value());
settings->endGroup();
settings->endGroup();
}