feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Use Core::AsynchronousMessageBox

Browse Source 
Event loops can lead to crashes so it is better to use a dialog which has
not it's own event loop.

Change-Id: Ib703aad698f270b1fa491731adee131ad8b081e6
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Marco Bubke
2014-11-25 11:45:43 +01:00
committed by Orgad Shaneh
parent e9a6e99011
commit cda1b6d246
4 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/git/settingspage.cpp
View File

@@ -35,11 +35,11 @@
#include <vcsbase/vcsbaseconstants.h>
#include <utils/hostosinfo.h>
#include <coreplugin/messagebox.h>
#include <QDir>
#include <QDebug>
#include <QTextStream>
#include <QMessageBox>
namespace Git {
namespace Internal {
@@ -118,7 +118,7 @@ void SettingsPage::apply()
QString errorMessage;
newSettings.gitExecutable(&gitFoundOk, &errorMessage);
if (!gitFoundOk)
QMessageBox::warning(m_widget, tr("Git Settings"), errorMessage);
Core::AsynchronousMessageBox::warning(tr("Git Settings"), errorMessage);
}
GitPlugin::instance()->setSettings(newSettings);