From cdb551404079bc5d1adac0c21ae080a73d79115c Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Thu, 11 Jan 2024 01:16:04 +0100
Subject: [PATCH] AppMan: Avoid using keys()

Instead, iterate directly over the container.

Change-Id: I56fbd18acd2faec7596141990f87e5be4f122639
Reviewed-by: Dominik Holland <dominik.holland@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
---
 src/plugins/qtapplicationmanager/appmanagerplugin.cpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/plugins/qtapplicationmanager/appmanagerplugin.cpp b/src/plugins/qtapplicationmanager/appmanagerplugin.cpp
index 9619f9e00e6..d62fba2a07e 100644
--- a/src/plugins/qtapplicationmanager/appmanagerplugin.cpp
+++ b/src/plugins/qtapplicationmanager/appmanagerplugin.cpp
@@ -55,10 +55,9 @@ void cloneAutodetectedBoot2QtKits()
                 }
             }
         }
-        for (auto qtVersion : boot2QtKits.keys()) {
-            if (!genericLinuxDeviceKits.contains(qtVersion)) {
-                const auto boot2QtKit = boot2QtKits.value(qtVersion);
-                const auto copyIntoKit = [boot2QtKit](Kit *k) {
+        for (auto it = boot2QtKits.cbegin(); it != boot2QtKits.cend(); ++it) {
+            if (!genericLinuxDeviceKits.contains(it.key())) {
+                const auto copyIntoKit = [boot2QtKit = *it](Kit *k) {
                     k->copyFrom(boot2QtKit);
                     k->setAutoDetected(false);
                     k->setUnexpandedDisplayName(QString("%1 for Generic Linux Devices").arg(boot2QtKit->unexpandedDisplayName()));