feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakePM: Ensure Initial Parameters values on build config Clone

Browse Source 
Fixes: QTCREATORBUG-28759
Change-Id: I8d7fa476ff487cf4bf5005f1ccfec65ffc59ed1c
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
Cristian Adam
2023-02-23 15:06:22 +01:00
parent 87c00b86db
commit cdee94d641
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp
View File

@@ -502,6 +502,10 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildSystem *bs) :
updateInitialCMakeArguments(); updateInitialCMakeArguments();
}); });
connect(m_buildSystem->target()->project(), &Project::aboutToSaveSettings, this, [this] {
updateInitialCMakeArguments();
});
connect(bc->aspect<InitialCMakeArgumentsAspect>(), connect(bc->aspect<InitialCMakeArgumentsAspect>(),
&Utils::BaseAspect::labelLinkActivated, &Utils::BaseAspect::labelLinkActivated,
this, this,

3
src/plugins/projectexplorer/buildsettingspropertiespage.cpp
View File

@@ -276,6 +276,9 @@ void BuildSettingsWidget::cloneConfiguration()
if (name.isEmpty()) if (name.isEmpty())
return; return;
// Save the current build configuration settings, so that the clone gets all the settings
m_target->project()->saveSettings();
BuildConfiguration *bc = BuildConfigurationFactory::clone(m_target, m_buildConfiguration); BuildConfiguration *bc = BuildConfigurationFactory::clone(m_target, m_buildConfiguration);
if (!bc) if (!bc)
return; return;