feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Move KitAspectWidget definitions alongside their KitAspects

Browse Source 
A KitAspectWidget class is tightly coupled with the respective
KitAspect, and no one else ever needs to see any KitAspectWidget
subclass at build time.

Change-Id: I1883af3b054c225e1ff5dd913118715bfdbaacfc
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2019-02-06 15:04:17 +01:00
parent c129b8cfe2
commit ce19540b77
36 changed files with 1235 additions and 787 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
src/plugins/android/androidgdbserverkitinformation.cpp
View File

@@ -50,6 +50,31 @@ using namespace Utils;
namespace Android {
namespace Internal {
class AndroidGdbServerKitAspectWidget : public KitAspectWidget
{
Q_DECLARE_TR_FUNCTIONS(Android::Internal::AndroidGdbServerKitAspect)
public:
AndroidGdbServerKitAspectWidget(Kit *kit, const KitAspect *ki);
~AndroidGdbServerKitAspectWidget() override;
QString displayName() const override;
QString toolTip() const override;
void makeReadOnly() override;
void refresh() override;
bool visibleInKit() override;
QWidget *mainWidget() const override;
QWidget *buttonWidget() const override;
private:
void autoDetectDebugger();
void showDialog();
QLabel *m_label;
QPushButton *m_button;
};
AndroidGdbServerKitAspect::AndroidGdbServerKitAspect()
{
setId(AndroidGdbServerKitAspect::id());

31
src/plugins/android/androidgdbserverkitinformation.h
View File

@@ -26,41 +26,10 @@
#pragma once
#include <projectexplorer/kitinformation.h>
#include <projectexplorer/kitconfigwidget.h>
QT_BEGIN_NAMESPACE
class QLabel;
class QPushButton;
QT_END_NAMESPACE
namespace Android {
namespace Internal {
class AndroidGdbServerKitAspectWidget : public ProjectExplorer::KitAspectWidget
{
Q_OBJECT
public:
AndroidGdbServerKitAspectWidget(ProjectExplorer::Kit *kit,
const ProjectExplorer::KitAspect *ki);
~AndroidGdbServerKitAspectWidget() override;
QString displayName() const override;
QString toolTip() const override;
void makeReadOnly() override;
void refresh() override;
bool visibleInKit() override;
QWidget *mainWidget() const override;
QWidget *buttonWidget() const override;
private:
void autoDetectDebugger();
void showDialog();
QLabel *m_label;
QPushButton *m_button;
};
class AndroidGdbServerKitAspect : public ProjectExplorer::KitAspect
{
Q_OBJECT