feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMakeProjectManager: Remove outdated todos

Browse Source 
Most of them are done, or are not really todos but just notes on
the code.

Change-Id: Idc4836844ee7bc1444e1251f97118bd9103a6019
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
This commit is contained in:
Daniel Teske
2012-05-03 16:05:03 +02:00
parent 3d9150075b
commit ce62c4bf91
5 changed files with 4 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/cmakeprojectmanager/cmakeopenprojectwizard.cpp
View File

@@ -30,15 +30,6 @@
**
**************************************************************************/
/// TODO
/// To check
/// a) with an old cmake
/// => should not show combobox always use mingw generator
/// b) with an new cmake
/// always show combo box, defaulting if there's already a existing build
#include "cmakeopenprojectwizard.h"
#include "cmakeprojectmanager.h"
@@ -419,7 +410,7 @@ void CMakeRunPage::initializePage()
}
// Build the list of generators/toolchains we want to offer
// todo restrict toolchains based on CMAKE_CXX_COMPILER ?
// restrict toolchains based on CMAKE_CXX_COMPILER ?
Q_UNUSED(cmakeCxxCompiler);
m_generatorComboBox->clear();
bool hasCodeBlocksGenerator = m_cmakeWizard->cmakeManager()->hasCodeBlocksMsvcGenerator();
@@ -554,7 +545,6 @@ void CMakeRunPage::cmakeFinished()
m_cmakeProcess->deleteLater();
m_cmakeProcess = 0;
m_cmakeWizard->setArguments(m_argumentsLineEdit->text());
//TODO Actually test that running cmake was finished, for setting this bool
emit completeChanged();
}