feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Fix enabling git actions after rebase

Browse Source 
Delay the state changed signal for proper evaluation
(a file check for `rebase-apply` is run when the
signal is emitted)

This fixes that Git "Rebasing" stayed in the title
bar when rebasing was long finished and therefore
the rebase actions stayed disabled.

TODO: The [REBASING] message in the projects view is
not fixed, it disappears when clicking the title bar.

Fixes: QTCREATORBUG-31815
Change-Id: Ic83949dfdaf26df3af8149457e3f282ff1bcefe5
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Andre Hartmann
2024-10-20 13:03:11 +02:00
committed by André Hartmann
parent 1ac403bacb
commit ce9826ae6e
1 changed files with 5 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/vcsbase/vcsbaseplugin.cpp
View File

@@ -30,6 +30,7 @@
#include <QSharedData> #include <QSharedData>
#include <QProcessEnvironment> #include <QProcessEnvironment>
#include <QTextCodec> #include <QTextCodec>
#include <QTimer>
using namespace Core; using namespace Core;
using namespace Utils; using namespace Utils;
@@ -308,8 +309,10 @@ void StateListener::slotStateChanged()
state.clearPatchFile(); // Need a repository to patch state.clearPatchFile(); // Need a repository to patch
qCDebug(stateLog).noquote() << "VC:" << (vc ? vc->displayName() : QString("None")) << state; qCDebug(stateLog).noquote() << "VC:" << (vc ? vc->displayName() : QString("None")) << state;
QTimer::singleShot(500, this, [this, state, vc] {
EditorManager::updateWindowTitles(); EditorManager::updateWindowTitles();
emit stateChanged(state, vc); emit stateChanged(state, vc);
});
} }
} // namespace Internal } // namespace Internal