feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectNodes: Use a set of flags for bools in Node

Browse Source 
This has the potential to save some space per node.

Change-Id: I2b8b65c13b355e680965bb7307f9e8d8714dae64
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Tobias Hunger
2017-05-03 12:24:53 +02:00
parent 175643fd7e
commit cea68a3fe3
2 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/projectexplorer/projectnodes.cpp
View File

@@ -209,7 +209,7 @@ QString Node::tooltip() const
bool Node::isEnabled() const bool Node::isEnabled() const
{ {
if (!m_isEnabled) if (!m_flags.testFlag(FlagIsEnabled))
return false; return false;
FolderNode *parent = parentFolderNode(); FolderNode *parent = parentFolderNode();
return parent ? parent->isEnabled() : true; return parent ? parent->isEnabled() : true;
@@ -222,9 +222,7 @@ bool Node::supportsAction(ProjectAction, Node *) const
void Node::setEnabled(bool enabled) void Node::setEnabled(bool enabled)
{ {
if (m_isEnabled == enabled) m_flags.setFlag(FlagIsEnabled, enabled);
return;
m_isEnabled = enabled;
} }
bool Node::sortByPath(const Node *a, const Node *b) bool Node::sortByPath(const Node *a, const Node *b)

7
src/plugins/projectexplorer/projectnodes.h
View File

@@ -161,7 +161,12 @@ private:
int m_line = -1; int m_line = -1;
int m_priority = DefaultPriority; int m_priority = DefaultPriority;
const NodeType m_nodeType; const NodeType m_nodeType;
bool m_isEnabled = true; enum NodeFlag : quint16 {
FlagNone = 0,
FlagIsEnabled = 1 << 0,
};
using NodeFlags = QFlags<NodeFlag>;
NodeFlags m_flags = FlagIsEnabled;
}; };
class PROJECTEXPLORER_EXPORT FileNode : public Node class PROJECTEXPLORER_EXPORT FileNode : public Node