feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectConfiguration: Clean up some constants

Browse Source 
Remove unnecessary constant and move others into the cpp file where
they are used.

Change-Id: Ib1e8ac69a39eb38794bbdafc860ca42ca29c3bdb
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2015-11-13 11:51:49 +01:00
parent 6d797a9097
commit cedf015c10
6 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/android/androiddeployconfiguration.cpp
View File

@@ -47,6 +47,9 @@ using namespace ProjectExplorer;
namespace Android { namespace Android {
namespace Internal { namespace Internal {
// Qt 5.2 has a new form of deployment
const char ANDROID_DEPLOYCONFIGURATION_ID[] = "Qt4ProjectManager.AndroidDeployConfiguration2";
AndroidDeployConfiguration::AndroidDeployConfiguration(Target *parent, Core::Id id) AndroidDeployConfiguration::AndroidDeployConfiguration(Target *parent, Core::Id id)
: DeployConfiguration(parent, id) : DeployConfiguration(parent, id)
{ {

4
src/plugins/android/androiddeployconfiguration.h
View File

@@ -36,10 +36,6 @@
namespace Android { namespace Android {
namespace Internal { namespace Internal {
// Qt 5.2 has a new form of deployment
const char ANDROID_DEPLOYCONFIGURATION_ID[] = "Qt4ProjectManager.AndroidDeployConfiguration2";
const char ANDROID_DC_PREFIX[] = "Qt4ProjectManager.AndroidDeployConfiguration2.";
class AndroidDeployConfiguration : public ProjectExplorer::DeployConfiguration class AndroidDeployConfiguration : public ProjectExplorer::DeployConfiguration
{ {
Q_OBJECT Q_OBJECT

2
src/plugins/baremetal/baremetalgdbcommandsdeploystep.cpp
View File

@@ -37,6 +37,8 @@ using namespace ProjectExplorer;
namespace BareMetal { namespace BareMetal {
namespace Internal { namespace Internal {
const char GdbCommandsKey[] = "BareMetal.GdbCommandsStep.Commands";
BareMetalGdbCommandsDeployStepWidget::BareMetalGdbCommandsDeployStepWidget(BareMetalGdbCommandsDeployStep &step) BareMetalGdbCommandsDeployStepWidget::BareMetalGdbCommandsDeployStepWidget(BareMetalGdbCommandsDeployStep &step)
: m_step(step) : m_step(step)
{ {

2
src/plugins/baremetal/baremetalgdbcommandsdeploystep.h
View File

@@ -68,8 +68,6 @@ private:
QString m_gdbCommands; QString m_gdbCommands;
}; };
const char GdbCommandsKey[] = "BareMetal.GdbCommandsStep.Commands";
class BareMetalGdbCommandsDeployStepWidget: public ProjectExplorer::BuildStepConfigWidget class BareMetalGdbCommandsDeployStepWidget: public ProjectExplorer::BuildStepConfigWidget
{ {
Q_OBJECT Q_OBJECT

3
src/plugins/ios/iosdeployconfiguration.cpp
View File

@@ -45,6 +45,9 @@ using namespace ProjectExplorer;
namespace Ios { namespace Ios {
namespace Internal { namespace Internal {
const char IOS_DEPLOYCONFIGURATION_ID[] = "Qt4ProjectManager.IosDeployConfiguration";
const char IOS_DC_PREFIX[] = "Qt4ProjectManager.IosDeployConfiguration.";
IosDeployConfiguration::IosDeployConfiguration(Target *parent, Core::Id id) IosDeployConfiguration::IosDeployConfiguration(Target *parent, Core::Id id)
: DeployConfiguration(parent, id) : DeployConfiguration(parent, id)
{ {

3
src/plugins/ios/iosdeployconfiguration.h
View File

@@ -35,9 +35,6 @@
namespace Ios { namespace Ios {
namespace Internal { namespace Internal {
const char IOS_DEPLOYCONFIGURATION_ID[] = "Qt4ProjectManager.IosDeployConfiguration";
const char IOS_DC_PREFIX[] = "Qt4ProjectManager.IosDeployConfiguration.";
class IosDeployConfiguration : public ProjectExplorer::DeployConfiguration class IosDeployConfiguration : public ProjectExplorer::DeployConfiguration
{ {
Q_OBJECT Q_OBJECT