feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't allocate unneeded temporary containers

Browse Source 
Fix clazy warnings: allocating an unneeded temporary container
[clazy-container-anti-pattern]

Change-Id: I4b4c2c634eea650bbdf3c12d982a17f899fc94ec
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2020-12-08 15:41:46 +01:00
parent 93dd966ce2
commit cf010911f7
25 changed files with 118 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/autotest/testsettings.cpp
View File

@@ -70,13 +70,14 @@ void TestSettings::toSettings(QSettings *s) const
s->setValue(popupOnFailKey, popupOnFail);
s->setValue(runAfterBuildKey, int(runAfterBuild));
// store frameworks and their current active and grouping state
for (const Utils::Id &id : frameworks.keys()) {
s->setValue(id.toString(), frameworks.value(id));
for (auto it = frameworks.cbegin(); it != frameworks.cend(); ++it) {
const Utils::Id &id = it.key();
s->setValue(id.toString(), it.value());
s->setValue(id.toString() + groupSuffix, frameworksGrouping.value(id));
}
// ..and the testtools as well
for (const Utils::Id &id : tools.keys())
s->setValue(id.toString(), tools.value(id));
for (auto it = tools.cbegin(); it != tools.cend(); ++it)
s->setValue(it.key().toString(), it.value());
s->endGroup();
}