feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't allocate unneeded temporary containers

Browse Source 
Fix clazy warnings: allocating an unneeded temporary container
[clazy-container-anti-pattern]

Change-Id: I4b4c2c634eea650bbdf3c12d982a17f899fc94ec
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
Reviewed-by: David Schulz <david.schulz@qt.io>
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2020-12-08 15:41:46 +01:00
parent 93dd966ce2
commit cf010911f7
25 changed files with 118 additions and 93 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/marketplace/productlistmodel.cpp
View File

@@ -333,7 +333,7 @@ void SectionedProducts::setColumnCount(int columns)
if (columns < 1)
columns = 1;
m_columnCount = columns;
for (ProductGridView *view : m_gridViews.values()) {
for (ProductGridView *view : qAsConst(m_gridViews)) {
view->setColumnCount(columns);
view->setFixedSize(view->viewportSizeHint());
}
@@ -361,7 +361,7 @@ void SectionedProducts::fetchNextImage()
if (QPixmapCache::find(nextUrl, nullptr)) {
// this image is already cached it might have been added while downloading
for (ProductListModel *model : m_productModels.values())
for (ProductListModel *model : qAsConst(m_productModels))
model->updateModelIndexesForUrl(nextUrl);
fetchNextImage();
return;
@@ -387,7 +387,7 @@ void SectionedProducts::onImageDownloadFinished(QNetworkReply *reply)
const QString url = imageUrl.toString();
QPixmapCache::insert(url, pixmap.scaled(ProductListModel::defaultImageSize,
Qt::KeepAspectRatio, Qt::SmoothTransformation));
for (ProductListModel *model : m_productModels.values())
for (ProductListModel *model : qAsConst(m_productModels))
model->updateModelIndexesForUrl(url);
}
} // handle error not needed - it's okay'ish to have no images as long as the rest works
@@ -411,7 +411,7 @@ void SectionedProducts::addNewSection(const Section &section, const QList<Core::
gridModel->setColumnCount(m_columnCount);
m_productModels.insert(section, productModel);
m_gridViews.insert(section, gridView);
const auto it = m_gridViews.insert(section, gridView);
QFont f = font();
f.setPixelSize(16);
@@ -421,7 +421,7 @@ void SectionedProducts::addNewSection(const Section &section, const QList<Core::
auto vbox = qobject_cast<QVBoxLayout *>(scrollArea->widget()->layout());
// insert new section depending on its priority, but before the last (stretch) item
int position = m_gridViews.keys().indexOf(section) * 2; // a section has a label and a grid
int position = std::distance(m_gridViews.begin(), it) * 2; // a section has a label and a grid
QTC_ASSERT(position <= vbox->count() - 1, position = vbox->count() - 1);
vbox->insertWidget(position, sectionLabel);
vbox->insertWidget(position + 1, gridView);
@@ -442,7 +442,7 @@ void SectionedProducts::onTagClicked(const QString &tag)
QList<Core::ListItem *> SectionedProducts::items()
{
QList<Core::ListItem *> result;
for (const ProductListModel *model : m_productModels.values())
for (const ProductListModel *model : qAsConst(m_productModels))
result.append(model->items());
return result;
}