From cf0d90f88e1bded84f454a1e8a0379a2836263a6 Mon Sep 17 00:00:00 2001 From: Thomas Hartmann Date: Mon, 18 Apr 2011 10:26:52 +0200 Subject: [PATCH] QmlDesigner.propertyEditor: crash fix Setting an empty expression on a value not defined in the model crashed. Task-number: QTCREATORBUG-4312 --- .../qmldesigner/components/propertyeditor/propertyeditor.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/plugins/qmldesigner/components/propertyeditor/propertyeditor.cpp b/src/plugins/qmldesigner/components/propertyeditor/propertyeditor.cpp index eb18766cf45..a6fff788f47 100644 --- a/src/plugins/qmldesigner/components/propertyeditor/propertyeditor.cpp +++ b/src/plugins/qmldesigner/components/propertyeditor/propertyeditor.cpp @@ -511,6 +511,9 @@ void PropertyEditor::changeExpression(const QString &name) return; } + if (value->expression().isEmpty()) + return; + if (fxObjectNode.expression(name) != value->expression() || !fxObjectNode.propertyAffectedByCurrentState(name)) fxObjectNode.setBindingProperty(name, value->expression());