From cf1377b6fe5fe43eb343f942a54a7b3b4cef6c3c Mon Sep 17 00:00:00 2001 From: Orgad Shaneh Date: Wed, 28 Jul 2021 18:57:36 +0300 Subject: [PATCH] ProjectExplorer: Remove pointless conversions in cloneConfiguration Change-Id: I80d48ba726111d18f2ee623efa0f44a1fd6e2654 Reviewed-by: hjk --- .../projectexplorer/buildsettingspropertiespage.cpp | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/plugins/projectexplorer/buildsettingspropertiespage.cpp b/src/plugins/projectexplorer/buildsettingspropertiespage.cpp index 0ff35e60b98..87c855b12d7 100644 --- a/src/plugins/projectexplorer/buildsettingspropertiespage.cpp +++ b/src/plugins/projectexplorer/buildsettingspropertiespage.cpp @@ -300,16 +300,13 @@ void BuildSettingsWidget::cloneConfiguration() return; bc->setDisplayName(name); - const std::function isBuildDirOk = [this](const QString &candidate) { - const auto fp = FilePath::fromString(candidate); - if (fp.exists()) + const std::function isBuildDirOk = [this](const FilePath &candidate) { + if (candidate.exists()) return false; - return !anyOf(m_target->buildConfigurations(), [&fp](const BuildConfiguration *bc) { - return bc->buildDirectory() == fp; }); + return !anyOf(m_target->buildConfigurations(), [&candidate](const BuildConfiguration *bc) { + return bc->buildDirectory() == candidate; }); }; - bc->setBuildDirectory(FilePath::fromString(makeUniquelyNumbered( - bc->buildDirectory().toString(), - isBuildDirOk))); + bc->setBuildDirectory(makeUniquelyNumbered(bc->buildDirectory(), isBuildDirOk)); m_target->addBuildConfiguration(bc); SessionManager::setActiveBuildConfiguration(m_target, bc, SetActive::Cascade); }