From cf142973e06569409963d3f8fd0ba1996107bbca Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Mon, 9 Dec 2013 12:52:51 +0100 Subject: [PATCH] QmlProfiler: Don't emit two changed() signals in a row Without this all the data is processed another time in all timeline models when the second signal is emitted. This is quite wasteful. Task-number: QTCREATORBUG-10950 Change-Id: Iac1315689e0900abb48efc1cf6390ec559a1897c Reviewed-by: Kai Koehne Reviewed-by: Eike Ziller --- src/plugins/qmlprofiler/qmlprofilerprocessedmodel.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmlprofiler/qmlprofilerprocessedmodel.cpp b/src/plugins/qmlprofiler/qmlprofilerprocessedmodel.cpp index 2e4331f735e..a09fe9b23d9 100644 --- a/src/plugins/qmlprofiler/qmlprofilerprocessedmodel.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerprocessedmodel.cpp @@ -114,9 +114,10 @@ QmlProfilerProcessedModel::~QmlProfilerProcessedModel() void QmlProfilerProcessedModel::clear() { m_detailsRewriter->clearRequests(); + + // This call emits changed(). Don't emit it again here. QmlProfilerSimpleModel::clear(); - emit changed(); m_emitChanged = false; } @@ -155,8 +156,9 @@ void QmlProfilerProcessedModel::complete() m_detailsRewriter->reloadDocuments(); + // This call emits changed(). Don't emit it again here. QmlProfilerSimpleModel::complete(); - emit changed(); + m_emitChanged = false; }