feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Restrict scope of stored signalOperation

Browse Source 
It's only actively alive between the attempt to stop, and being
stopped. Having it stored in 'global' member variable was a
workaround in pre-lambda times.

Change-Id: I169745afd7985ed9038edff763026c32f82f6126
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2017-08-17 10:37:05 +02:00
parent 2a62a72c69
commit cf1edc1fb5
2 changed files with 14 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/debugger/gdb/gdbengine.h
View File

@@ -36,12 +36,10 @@
#include <coreplugin/id.h>
#include <projectexplorer/devicesupport/idevice.h>
#include <utils/qtcprocess.h>
#include <QProcess>
#include <QTextCodec>
#include <QTime>
#include <QTimer>
#include <functional>
@@ -128,7 +126,6 @@ protected: ////////// Gdb Process Management //////////
private:
friend class GdbPlainEngine;
friend class GdbCoreEngine;
void handleInterruptDeviceInferior(const QString &error);
void handleGdbFinished(int exitCode, QProcess::ExitStatus exitStatus);
void handleGdbError(QProcess::ProcessError error);
void readGdbStandardOutput();
@@ -422,7 +419,6 @@ protected:
protected:
Utils::QtcProcess m_gdbProc;
QString m_errorString;
ProjectExplorer::DeviceProcessSignalOperation::Ptr m_signalOperation;
};
} // namespace Internal