Fix occurrences of the contains/insert anti-pattern

Introduce and make use of Utils::insert() for QSet with a return value
that indicates whether insertion actually happened.

Change-Id: I655e4bc3553b74fea5ae8956205e4d8070118d63
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Christian Kandeler
2023-06-22 14:58:11 +02:00
parent ae33199d04
commit cf6bd7e012
39 changed files with 107 additions and 169 deletions

View File

@@ -131,10 +131,9 @@ static QStringList readLines(const FilePath &projectFile)
const QString line = stream.readLine();
if (line.isNull())
break;
if (visited.contains(line))
if (!Utils::insert(visited, line))
continue;
lines.append(line);
visited.insert(line);
}
}
@@ -149,10 +148,8 @@ static QStringList readLinesJson(const FilePath &projectFile, QString *errorMess
const QJsonObject obj = readObjJson(projectFile, errorMessage);
for (const QJsonValue &file : obj.value("files").toArray()) {
const QString fileName = file.toString();
if (visited.contains(fileName))
continue;
lines.append(fileName);
visited.insert(fileName);
if (Utils::insert(visited, fileName))
lines.append(fileName);
}
return lines;