From cfa46fa97442285d4a369f2a0ea72934f9659616 Mon Sep 17 00:00:00 2001 From: Amr Essam Date: Mon, 30 Oct 2023 09:29:33 +0200 Subject: [PATCH] QmlDesigner: Fix textures not render in effect maker Task-number: QDS-11064 Change-Id: If300e61e389f66928787bf02273c9356a1a76185 Reviewed-by: Mahmoud Badri --- .../qmldesigner/effectMakerQmlSources/ValueImage.qml | 3 ++- src/plugins/effectmakernew/effectmakermodel.cpp | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/share/qtcreator/qmldesigner/effectMakerQmlSources/ValueImage.qml b/share/qtcreator/qmldesigner/effectMakerQmlSources/ValueImage.qml index 571fac50002..acf70f0a759 100644 --- a/share/qtcreator/qmldesigner/effectMakerQmlSources/ValueImage.qml +++ b/share/qtcreator/qmldesigner/effectMakerQmlSources/ValueImage.qml @@ -18,6 +18,7 @@ Row { actionIndicatorVisible: false - onAbsoluteFilePathChanged: uniformValue = absoluteFilePath + //TODO: Disable until we figure out how to use images from outside qds + //onAbsoluteFilePathChanged: uniformValue = absoluteFilePath } } diff --git a/src/plugins/effectmakernew/effectmakermodel.cpp b/src/plugins/effectmakernew/effectmakermodel.cpp index 0745536cf23..7f8296fd3c7 100644 --- a/src/plugins/effectmakernew/effectmakermodel.cpp +++ b/src/plugins/effectmakernew/effectmakermodel.cpp @@ -462,9 +462,11 @@ QString EffectMakerModel::valueAsVariable(const Uniform &uniform) // Return name for the image property Image element QString EffectMakerModel::getImageElementName(const Uniform &uniform) { - // TODO - Q_UNUSED(uniform) - return {}; + if (uniform.value().toString().isEmpty()) + return QStringLiteral("null"); + QString simplifiedName = uniform.name().simplified(); + simplifiedName = simplifiedName.remove(' '); + return QStringLiteral("imageItem") + simplifiedName; } const QString EffectMakerModel::getConstVariables()