feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Some more QStringList cleanup

Browse Source 
Change-Id: I0c6e8f768ee46985dab8ae14f88f2bc8d34fed26
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Orgad Shaneh
2016-07-24 10:10:44 +03:00
committed by Orgad Shaneh
parent fedf5de551
commit cfc8ed41c7
8 changed files with 13 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/git/gerrit/gerritparameters.cpp
View File

@@ -72,7 +72,7 @@ void GerritParameters::setPortFlagBySshType()
{
bool isPlink = false;
if (!ssh.isEmpty()) {
const QString version = Utils::PathChooser::toolVersion(ssh, QStringList("-V"));
const QString version = Utils::PathChooser::toolVersion(ssh, { "-V" });
isPlink = version.contains("plink", Qt::CaseInsensitive);
}
portFlag = QLatin1String(isPlink ? "-P" : defaultPortFlag);
@@ -88,10 +88,7 @@ GerritParameters::GerritParameters()
QStringList GerritParameters::baseCommandArguments() const
{
QStringList result;
result << ssh << portFlag << QString::number(port)
<< sshHostArgument() << "gerrit";
return result;
return { ssh, portFlag, QString::number(port), sshHostArgument(), "gerrit" };
}
QString GerritParameters::sshHostArgument() const