feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Split MemCheck and CallGrind factories

Browse Source 
The tools are separated everywhere, lumping them into the same
RunControlFactory removes modularity artificially.

Change-Id: I8d9e917bb114a1898a0c293f18d3bf78a52075aa
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2016-03-07 17:33:58 +01:00
parent 494f4a7742
commit d02919d850
11 changed files with 117 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/valgrind/memcheckengine.cpp
View File

@@ -128,8 +128,8 @@ QStringList MemcheckRunControl::suppressionFiles() const
return m_settings->suppressionFiles();
}
MemcheckWithGdbRunControl::MemcheckWithGdbRunControl(RunConfiguration *runConfiguration)
: MemcheckRunControl(runConfiguration, MEMCHECK_WITH_GDB_RUN_MODE)
MemcheckWithGdbRunControl::MemcheckWithGdbRunControl(RunConfiguration *runConfiguration, Core::Id runMode)
: MemcheckRunControl(runConfiguration, runMode)
{
connect(&m_runner, &Memcheck::MemcheckRunner::started,
this, &MemcheckWithGdbRunControl::startDebugger);