Help: Reduce number of HelpItem constructors

Change-Id: I4ae1b0804a630dc7e2da3e14953dc36d07136603
Reviewed-by: David Schulz <david.schulz@qt.io>

src/plugins/coreplugin/helpitem.cpp

@@ -40,10 +40,6 @@ HelpItem::HelpItem(const QString &helpId)
     : m_helpId(helpId)
 {}
 
-HelpItem::HelpItem(const QString &helpId, Category category) :
-    m_helpId(helpId), m_docMark(helpId), m_category(category)
-{}
-
 HelpItem::HelpItem(const QString &helpId, const QString &docMark, Category category) :
     m_helpId(helpId), m_docMark(docMark), m_category(category)
 {}
@@ -53,9 +49,6 @@ HelpItem::HelpItem(const QString &helpId, const QString &docMark, Category categ
     m_helpId(helpId), m_docMark(docMark), m_category(category), m_helpLinks(helpLinks)
 {}
 
-HelpItem::~HelpItem()
-{}
-
 void HelpItem::setHelpId(const QString &id)
 { m_helpId = id; }
 

src/plugins/coreplugin/helpitem.h

@@ -54,11 +54,9 @@ public:
     HelpItem();
     HelpItem(const char *helpId);
     HelpItem(const QString &helpId);
-    HelpItem(const QString &helpId, Category category);
     HelpItem(const QString &helpId, const QString &docMark, Category category);
     HelpItem(const QString &helpId, const QString &docMark, Category category,
              const QMap<QString, QUrl> &helpLinks);
-    ~HelpItem();
 
     void setHelpId(const QString &id);
     const QString &helpId() const;

src/plugins/qmakeprojectmanager/profilehoverhandler.cpp

@@ -68,8 +68,7 @@ void ProFileHoverHandler::identifyMatch(TextEditor::TextEditorWidget *editorWidg
                                                      Core::HelpItem::QMakeVariableOfFunction));
         } else {
             // General qmake manual will be shown outside any function or variable
-            setLastHelpItemIdentified(
+            setLastHelpItemIdentified("qmake");
-                Core::HelpItem(QLatin1String("qmake"), Core::HelpItem::Unknown));
         }
     }
 }