AutoTest: Some layout polishing

Layouts are simpler nowadays. Some drive-by formatting
changes.

Change-Id: If5fd0ff8cf8e39487bfb29d792bdf2d8ddb0342c
Reviewed-by: hjk <hjk@qt.io>

src/plugins/autotest/boost/boosttestsettings.cpp

@@ -65,7 +65,7 @@ BoostTestSettings::BoostTestSettings(Id settingsId)
     seed.setEnabled(false);
     seed.setLabelText(Tr::tr("Seed:"));
     seed.setToolTip(Tr::tr("A seed of 0 means no randomization. A value of 1 uses the current "
-        "time, any other value is used as random seed generator."));
+                           "time, any other value is used as random seed generator."));
     seed.setEnabler(&randomize);
 
     registerAspect(&randomize);

src/plugins/autotest/catch/catchtestsettings.cpp

@@ -23,7 +23,7 @@ CatchTestSettings::CatchTestSettings(Id settingsId)
     setSettingsGroups("Autotest", "Catch2");
 
     setLayouter([this](QWidget *widget) {
-        Column { Row { Grid {
+        Row { Form {
             showSuccess, br,
             breakOnFailure, br,
             noThrow, br,
@@ -34,7 +34,7 @@ CatchTestSettings::CatchTestSettings(Id settingsId)
             confidenceIntervalChecked, confidenceInterval, br,
             warmupChecked, benchmarkWarmupTime, br,
             noAnalysis
-        }, st }, st }.attachTo(widget);
+        }, st }.attachTo(widget);
     });
 
     registerAspect(&abortAfter);

src/plugins/autotest/ctest/ctestsettings.cpp

@@ -21,7 +21,7 @@ CTestSettings::CTestSettings(Id settingsId)
     setDisplayName(Tr::tr("CTest"));
 
     setLayouter([this](QWidget *w) {
-        Column { Row { Form {
+        Row { Form {
             outputOnFail, br,
             scheduleRandom, br,
             stopOnFailure, br,
@@ -39,7 +39,7 @@ CTestSettings::CTestSettings(Id settingsId)
                     Row { testLoad, threshold}
                 }
             }
-        }, st }, st }.attachTo(w);
+        }, st }.attachTo(w);
     });
 
     registerAspect(&outputOnFail);
@@ -95,7 +95,7 @@ CTestSettings::CTestSettings(Id settingsId)
     testLoad.setSettingsKey("TestLoad");
     testLoad.setLabelText(Tr::tr("Test load"));
     testLoad.setToolTip(Tr::tr("Try not to start tests when they may cause CPU load to pass a "
-                           "threshold."));
+                               "threshold."));
 
     registerAspect(&threshold);
     threshold.setSettingsKey("Threshold");

src/plugins/autotest/gtest/gtestsettings.cpp

@@ -24,18 +24,14 @@ GTestSettings::GTestSettings(Id settingsId)
     setDisplayName(Tr::tr(GTest::Constants::FRAMEWORK_SETTINGS_CATEGORY));
 
     setLayouter([this](QWidget *widget) {
-        Column { Row { Column {
+        Row { Form {
-            Grid {
                 runDisabled, br,
                 breakOnFailure, br,
                 repeat, iterations, br,
-                shuffle, seed
+                shuffle, seed, br,
-            },
+                groupMode, br,
-            Form {
+                gtestFilter, br
-                groupMode,
+            }, st }.attachTo(widget);
-                gtestFilter
-            }
-        }, st }, st }.attachTo(widget);
     });
 
     registerAspect(&iterations);
@@ -66,7 +62,8 @@ GTestSettings::GTestSettings(Id settingsId)
     registerAspect(&repeat);
     repeat.setSettingsKey("Repeat");
     repeat.setLabelText(Tr::tr("Repeat tests"));
-    repeat.setToolTip(Tr::tr("Repeats a test run (you might be required to increase the timeout to avoid canceling the tests)."));
+    repeat.setToolTip(Tr::tr("Repeats a test run (you might be required to increase the timeout to "
+                             "avoid canceling the tests)."));
 
     registerAspect(&throwOnFailure);
     throwOnFailure.setSettingsKey("ThrowOnFailure");
@@ -110,8 +107,8 @@ GTestSettings::GTestSettings(Id settingsId)
     });
     gtestFilter.setEnabled(false);
     gtestFilter.setLabelText(Tr::tr("Active filter:"));
-    gtestFilter.setToolTip(Tr::tr("Set the GTest filter to be used for grouping.\n"
+    gtestFilter.setToolTip(Tr::tr("Set the GTest filter to be used for grouping.\nSee Google Test "
-        "See Google Test documentation for further information on GTest filters."));
+                                  "documentation for further information on GTest filters."));
 
     gtestFilter.setValidationFunction([](FancyLineEdit *edit, QString * /*error*/) {
         return edit && GTestUtils::isValidGTestFilter(edit->text());

src/plugins/autotest/qtest/qttestsettings.cpp

@@ -23,21 +23,18 @@ QtTestSettings::QtTestSettings(Id settingsId)
     setDisplayName(Tr::tr(QtTest::Constants::FRAMEWORK_SETTINGS_CATEGORY));
 
     setLayouter([this](QWidget *widget) {
-        Column { Row { Column {
+        Row { Form {
-            noCrashHandler,
+            noCrashHandler, br,
-            useXMLOutput,
+            useXMLOutput, br,
-            verboseBench,
+            verboseBench, br,
-            logSignalsSlots,
+            logSignalsSlots, br,
-            Row {
+            limitWarnings, maxWarnings, br,
-                limitWarnings, maxWarnings
-            },
             Group {
                 title(Tr::tr("Benchmark Metrics")),
                 Column { metrics }
-            },
+            }, br,
-            br,
+            quickCheckForDerivedTests, br
-            quickCheckForDerivedTests,
+        }, st }.attachTo(widget);
-        }, st }, st }.attachTo(widget);
     });
 
     registerAspect(&metrics);
@@ -68,8 +65,8 @@ QtTestSettings::QtTestSettings(Id settingsId)
     useXMLOutput.setDefaultValue(true);
     useXMLOutput.setLabelText(Tr::tr("Use XML output"));
     useXMLOutput.setToolTip(Tr::tr("XML output is recommended, because it avoids parsing issues, "
-        "while plain text is more human readable.\n\n"
+                                   "while plain text is more human readable.\n\nWarning: "
-        "Warning: Plain text misses some information, such as duration."));
+                                   "Plain text misses some information, such as duration."));
 
     registerAspect(&verboseBench);
     verboseBench.setSettingsKey("VerboseBench");