feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Add a ProjectConfiguration::target()

Browse Source 
... with a suitable default implementation accessing a member
populated at construction time instead of walking the parent
chains on each access.

Change-Id: I58dae6da80ed0b023cc603fca13a5a205b123672
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-07-26 16:08:13 +02:00
parent 8493a6b044
commit d16330de6d
16 changed files with 42 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/projectexplorer/deployconfiguration.cpp
View File

@@ -44,6 +44,7 @@ DeployConfiguration::DeployConfiguration(Target *target, Core::Id id)
: ProjectConfiguration(target, id),
m_stepList(this, Constants::BUILDSTEPS_DEPLOY)
{
QTC_CHECK(target && target == this->target());
Utils::MacroExpander *expander = macroExpander();
expander->setDisplayName(tr("Deploy Settings"));
expander->setAccumulating(true);
@@ -108,16 +109,6 @@ bool DeployConfiguration::fromMap(const QVariantMap &map)
return true;
}
Target *DeployConfiguration::target() const
{
return static_cast<Target *>(parent());
}
Project *DeployConfiguration::project() const
{
return target()->project();
}
bool DeployConfiguration::isActive() const
{
return target()->isActive() && target()->activeDeployConfiguration() == this;