feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Add a ProjectConfiguration::target()

Browse Source 
... with a suitable default implementation accessing a member
populated at construction time instead of walking the parent
chains on each access.

Change-Id: I58dae6da80ed0b023cc603fca13a5a205b123672
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-07-26 16:08:13 +02:00
parent 8493a6b044
commit d16330de6d
16 changed files with 42 additions and 79 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/qbsprojectmanager/qbsbuildconfiguration.cpp
View File

@@ -158,21 +158,21 @@ QVariantMap QbsBuildConfiguration::qbsConfiguration() const
return config;
}
Internal::QbsProject *QbsBuildConfiguration::project() const
Internal::QbsProject *QbsBuildConfiguration::qbsProject() const
{
return qobject_cast<Internal::QbsProject *>(BuildConfiguration::project());
return qobject_cast<Internal::QbsProject *>(project());
}
bool QbsBuildConfiguration::isEnabled() const
{
return !project()->isParsing() && project()->hasParseResult();
return !project()->isParsing() && qbsProject()->hasParseResult();
}
QString QbsBuildConfiguration::disabledReason() const
{
if (project()->isParsing())
return tr("Parsing the Qbs project.");
if (!project()->hasParseResult())
if (!qbsProject()->hasParseResult())
return tr("Parsing of Qbs project has failed.");
return QString();
}

2
src/plugins/qbsprojectmanager/qbsbuildconfiguration.h
View File

@@ -53,7 +53,7 @@ public:
QbsBuildStep *qbsStep() const;
QVariantMap qbsConfiguration() const;
Internal::QbsProject *project() const override;
Internal::QbsProject *qbsProject() const;
bool isEnabled() const override;
QString disabledReason() const override;