From d22b87826bc47cd62f4285b9a367717b8ec8c33d Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 14 Jan 2025 17:10:12 +0100 Subject: [PATCH] CppEditor: Use scroll area in dialog for InsertDefsOperation Fixes: QTCREATORBUG-32193 Change-Id: I8c3930c3c85e7bf6f2c7005f4489ff758c710e09 Reviewed-by: Christian Stenger --- .../cppeditor/quickfixes/insertfunctiondefinition.cpp | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/plugins/cppeditor/quickfixes/insertfunctiondefinition.cpp b/src/plugins/cppeditor/quickfixes/insertfunctiondefinition.cpp index b0eda5e33c0..1d5378c80c1 100644 --- a/src/plugins/cppeditor/quickfixes/insertfunctiondefinition.cpp +++ b/src/plugins/cppeditor/quickfixes/insertfunctiondefinition.cpp @@ -22,6 +22,7 @@ #include #include #include +#include #ifdef WITH_TESTS #include "cppquickfix_test.h" @@ -256,7 +257,8 @@ public: defaultImplTargetLayout->addWidget(new QLabel(Tr::tr("Default implementation location:"))); defaultImplTargetLayout->addWidget(defaultImplTargetComboBox); - const auto candidatesLayout = new QGridLayout; + const auto candidatesWidget = new QWidget; + const auto candidatesLayout = new QGridLayout(candidatesWidget); Overview oo = CppCodeStyleSettings::currentProjectCodeStyleOverview(); oo.showFunctionSignatures = true; oo.showReturnTypes = true; @@ -272,6 +274,8 @@ public: i, 0); candidatesLayout->addWidget(implTargetComboBox, i, 1); } + const auto scrollArea = new QScrollArea; + scrollArea->setWidget(candidatesWidget); const auto buttonBox = new QDialogButtonBox(QDialogButtonBox::Ok | QDialogButtonBox::Cancel); @@ -282,7 +286,7 @@ public: const auto mainLayout = new QVBoxLayout(this); mainLayout->addLayout(defaultImplTargetLayout); mainLayout->addWidget(Layouting::createHr(this)); - mainLayout->addLayout(candidatesLayout); + mainLayout->addWidget(scrollArea); mainLayout->addWidget(buttonBox); }