From d24e5752782c037bb17090afd43c9b63fba1bc29 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Wed, 13 Dec 2023 10:10:15 +0100 Subject: [PATCH] LanguageClient: fix crash in completion assist Check m_processor again after starting. There is a callback resetting the processor and we cannot ensure that starting the processor does not result in calling this callback. Change-Id: I4dca31399fb5224234c81df36edcb7b75d9ceaef Reviewed-by: hjk Reviewed-by: Eike Ziller --- src/plugins/languageclient/languageclientcompletionassist.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/plugins/languageclient/languageclientcompletionassist.cpp b/src/plugins/languageclient/languageclientcompletionassist.cpp index 96aebde7850..56ac11bdede 100644 --- a/src/plugins/languageclient/languageclientcompletionassist.cpp +++ b/src/plugins/languageclient/languageclientcompletionassist.cpp @@ -317,7 +317,7 @@ public: }); setProposal(m_processor->start(std::move(interface)), prefix); - if (!m_processor->running()) { + if (m_processor && !m_processor->running()) { delete m_processor; m_processor = nullptr; }