feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Don't clash signal names with other methods

Browse Source 
In case when signal name clashes with other method name -
rename accordingly.
Remove some repeated signal declarations - they are already
declared in superclass.

Change-Id: Ie1430b85d6436d26996494fa44c7554fb354b6ce
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Jarek Kobus
2020-11-17 15:50:11 +01:00
parent c3a8429dc8
commit d2e1feceac
15 changed files with 26 additions and 45 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/shared/help/bookmarkmanager.cpp
View File

@@ -99,7 +99,7 @@ BookmarkDialog::BookmarkDialog(BookmarkManager *manager, const QString &title,
this, &BookmarkDialog::selectBookmarkFolder);
connect(ui.treeView, &TreeView::customContextMenuRequested,
this, &BookmarkDialog::customContextMenuRequested);
this, &BookmarkDialog::showContextMenu);
connect(ui.treeView->selectionModel(), &QItemSelectionModel::currentChanged,
this, &BookmarkDialog::currentChanged);
@@ -208,7 +208,7 @@ void BookmarkDialog::selectBookmarkFolder(int index)
}
}
void BookmarkDialog::customContextMenuRequested(const QPoint &point)
void BookmarkDialog::showContextMenu(const QPoint &point)
{
QModelIndex index = ui.treeView->indexAt(point);
if (!index.isValid())