feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VCS: Remove reading of very old settings

Browse Source 
Change-Id: Id75da5d764c0ea65942c49324c2db6d033cf62a1
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
Eike Ziller
2021-02-16 14:26:01 +01:00
parent 02e34e5760
commit d2f7bea0b6
6 changed files with 0 additions and 43 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/plugins/cvs/cvssettings.cpp
View File

@@ -69,19 +69,5 @@ QStringList CvsSettings::addOptions(const QStringList &args) const
return rc;
}
void CvsSettings::readLegacySettings(const QSettings *settings)
{
const QString keyRoot = settingsGroup() + QLatin1Char('/');
const QString oldBinaryPathKey = keyRoot + QLatin1String("Command");
const QString oldPromptOnSubmitKey = keyRoot + QLatin1String("PromptForSubmit");
const QString oldTimeoutKey = keyRoot + QLatin1String("TimeOut");
if (settings->contains(oldBinaryPathKey))
this->setValue(binaryPathKey, settings->value(oldBinaryPathKey).toString());
if (settings->contains(oldPromptOnSubmitKey))
this->setValue(promptOnSubmitKey, settings->value(oldPromptOnSubmitKey).toBool());
if (settings->contains(oldTimeoutKey))
this->setValue(timeoutKey, settings->value(oldTimeoutKey).toInt());
}
} // namespace Internal
} // namespace Cvs

3
src/plugins/cvs/cvssettings.h
View File

@@ -44,9 +44,6 @@ public:
int timeOutMs() const;
QStringList addOptions(const QStringList &args) const;
protected:
void readLegacySettings(const QSettings *settings) override;
};
} // namespace Internal

14
src/plugins/subversion/subversionsettings.cpp
View File

@@ -58,19 +58,5 @@ bool SubversionSettings::hasAuthentication() const
return boolValue(useAuthenticationKey) && !stringValue(userKey).isEmpty();
}
void SubversionSettings::readLegacySettings(const QSettings *settings)
{
const QString keyRoot = settingsGroup() + QLatin1Char('/');
const QString oldBinaryPathKey = keyRoot + QLatin1String("Command");
const QString oldPromptOnSubmitKey = keyRoot + QLatin1String("PromptForSubmit");
const QString oldTimeoutKey = keyRoot + QLatin1String("TimeOut");
if (settings->contains(oldBinaryPathKey))
this->setValue(binaryPathKey, settings->value(oldBinaryPathKey).toString());
if (settings->contains(oldPromptOnSubmitKey))
this->setValue(promptOnSubmitKey, settings->value(oldPromptOnSubmitKey).toBool());
if (settings->contains(oldTimeoutKey))
this->setValue(timeoutKey, settings->value(oldTimeoutKey).toInt());
}
} // namespace Internal
} // namespace Subversion

3
src/plugins/subversion/subversionsettings.h
View File

@@ -42,9 +42,6 @@ public:
SubversionSettings();
bool hasAuthentication() const;
protected:
void readLegacySettings(const QSettings *settings) override;
};
} // namespace Internal

7
src/plugins/vcsbase/vcsbaseclientsettings.cpp
View File

@@ -258,8 +258,6 @@ void VcsBaseClientSettings::readSettings(const QSettings *settings)
break;
}
}
this->readLegacySettings(settings);
}
bool VcsBaseClientSettings::equals(const VcsBaseClientSettings &rhs) const
@@ -397,9 +395,4 @@ QVariant VcsBaseClientSettings::keyDefaultValue(const QString &key) const
return QVariant(valueType(key));
}
void VcsBaseClientSettings::readLegacySettings(const QSettings *settings)
{
Q_UNUSED(settings)
}
} // namespace VcsBase

2
src/plugins/vcsbase/vcsbaseclientsettings.h
View File

@@ -89,8 +89,6 @@ protected:
void declareKey(const QString &key, const QVariant &defaultValue);
QVariant keyDefaultValue(const QString &key) const;
virtual void readLegacySettings(const QSettings *settings);
private:
friend bool equals(const VcsBaseClientSettings &rhs);
friend class VcsBaseClientSettingsPrivate;