From fa0e63ca7ab9fee37a513a1f45c2106e08ff0558 Mon Sep 17 00:00:00 2001
From: Kai Koehne <kai.koehne@nokia.com>
Date: Wed, 23 Nov 2011 14:01:02 +0100
Subject: [PATCH 01/14] QMakeStep: Fix compilation warning

Remove unused variable.

Change-Id: I8e060a8569edfa34483497188d480e624fc2c5fe
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
---
 src/plugins/qt4projectmanager/qmakestep.cpp | 2 --
 1 file changed, 2 deletions(-)

diff --git a/src/plugins/qt4projectmanager/qmakestep.cpp b/src/plugins/qt4projectmanager/qmakestep.cpp
index 7ea921ec589..c1908c35fdb 100644
--- a/src/plugins/qt4projectmanager/qmakestep.cpp
+++ b/src/plugins/qt4projectmanager/qmakestep.cpp
@@ -704,8 +704,6 @@ void QMakeStepConfigWidget::updateSummaryLabel()
 void QMakeStepConfigWidget::updateQmlDebuggingOption()
 {
     m_ui->qmlDebuggingLibraryCheckBox->setEnabled(m_step->isQmlDebuggingLibrarySupported());
-
-    QtSupport::BaseQtVersion *qtVersion = m_step->qt4BuildConfiguration()->qtVersion();
     m_ui->debuggingLibraryLabel->setText(tr("Enable QML debugging:"));
 
     QString warningText;

From 1fbf4d9a554433a28181a69105819f64c36c2db6 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@nokia.com>
Date: Mon, 28 Nov 2011 11:08:15 +0100
Subject: [PATCH 02/14] Fix tab settings for non-code files.

In the case when they are part of the project. The project's
EditorConfiguration had an wrongly initialized default editor setting.

Change-Id: If6e39ed3efca39d726c28b8278a059c8bbe7c3fc
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
---
 src/plugins/projectexplorer/editorconfiguration.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/plugins/projectexplorer/editorconfiguration.cpp b/src/plugins/projectexplorer/editorconfiguration.cpp
index a44cf0f9b10..f42c8a11e91 100644
--- a/src/plugins/projectexplorer/editorconfiguration.cpp
+++ b/src/plugins/projectexplorer/editorconfiguration.cpp
@@ -111,6 +111,8 @@ EditorConfiguration::EditorConfiguration() : d(new EditorConfigurationPrivate)
     d->m_defaultCodeStyle->setDelegatingPool(textEditorSettings->codeStylePool());
     d->m_defaultCodeStyle->setDisplayName(tr("Project", "Settings"));
     d->m_defaultCodeStyle->setId(kId);
+    d->m_defaultCodeStyle->setCurrentDelegate(d->m_useGlobal
+                    ? TextEditorSettings::instance()->codeStyle() : 0);
 }
 
 EditorConfiguration::~EditorConfiguration()

From b98aec872e091520ed261edf7476d6aa22ff4de3 Mon Sep 17 00:00:00 2001
From: hjk <qtc-committer@nokia.com>
Date: Mon, 28 Nov 2011 10:45:10 +0100
Subject: [PATCH 03/14] translations: update link to wiki page

Change-Id: I4e7a4636e2af4f1cb4af1039473038e906693b2d
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
---
 share/qtcreator/translations/README | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/share/qtcreator/translations/README b/share/qtcreator/translations/README
index f124f887593..1fdfe24fc6c 100644
--- a/share/qtcreator/translations/README
+++ b/share/qtcreator/translations/README
@@ -3,7 +3,7 @@ How To add translations to Qt Creator
 
 - Coordinate over the mailing list to avoid duplicate work.
 
-- Read the instructions at http://qt.gitorious.org/qt/pages/QtLocalization
+- Read the instructions at http://wiki.qt-project.org/Qt_Localization
 
 - Add your language to the LANGUAGES line in translations.pro.
   Don't qualify it with a country unless it is reasonable to expect

From 09bb332f09c8975dad4f448cc786cfb022111e00 Mon Sep 17 00:00:00 2001
From: Christian Kamm <christian.d.kamm@nokia.com>
Date: Tue, 29 Nov 2011 08:44:14 +0100
Subject: [PATCH 04/14] QmlJS: Add protection against attached types attaching
 to themselves.

Change-Id: Ib81d5e6baabf5ac8d18411e8936098908de2c2bb
Task-number: QTCREATORBUG-6635
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
(cherry picked from commit 25842cb13a18ec946fe80b6d869f2b00dbd2ce9c)
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
---
 src/libs/qmljs/qmljsinterpreter.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libs/qmljs/qmljsinterpreter.cpp b/src/libs/qmljs/qmljsinterpreter.cpp
index 9aafaeea910..0012fa40ca9 100644
--- a/src/libs/qmljs/qmljsinterpreter.cpp
+++ b/src/libs/qmljs/qmljsinterpreter.cpp
@@ -261,7 +261,7 @@ void QmlObjectValue::processMembers(MemberProcessor *processor) const
     const QString &attachedTypeName = _metaObject->attachedTypeName();
     if (!attachedTypeName.isEmpty()) {
         const QmlObjectValue *attachedType = valueOwner()->cppQmlTypes().objectByCppName(attachedTypeName);
-        if (attachedType)
+        if (attachedType && attachedType != this) // ### only weak protection against infinite loops
             attachedType->processMembers(processor);
     }
 

From d8add9504926add171f76f97ea65b49d13b6d823 Mon Sep 17 00:00:00 2001
From: Christian Kamm <christian.d.kamm@nokia.com>
Date: Tue, 29 Nov 2011 12:53:06 +0100
Subject: [PATCH 05/14] QmlJS: Fix potential crash in find usages.

When invalid documents or documents without idEnvironment or rootScope
get added to a QmlComponentChain.

Change-Id: I64b7062881f19777ba20efda6efa2e7bab02571e
Reviewed-by: Leandro Melo <leandro.melo@nokia.com>
(cherry picked from commit 9b411ed5588db9dcbea955e4e45f99b5d06c1cbe)
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
---
 src/plugins/qmljseditor/qmljsfindreferences.cpp | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/plugins/qmljseditor/qmljsfindreferences.cpp b/src/plugins/qmljseditor/qmljsfindreferences.cpp
index 49b18e499d2..1dddc575de1 100644
--- a/src/plugins/qmljseditor/qmljsfindreferences.cpp
+++ b/src/plugins/qmljseditor/qmljsfindreferences.cpp
@@ -246,13 +246,14 @@ protected:
 private:
     bool contains(const QmlComponentChain *chain)
     {
-        if (!chain || !chain->document())
+        if (!chain || !chain->document() || !chain->document()->bind())
             return false;
 
-        if (chain->document()->bind()->idEnvironment()->lookupMember(_name, _scopeChain.context()))
-            return chain->document()->bind()->idEnvironment() == _scope;
+        const ObjectValue *idEnv = chain->document()->bind()->idEnvironment();
+        if (idEnv && idEnv->lookupMember(_name, _scopeChain.context()))
+            return idEnv == _scope;
         const ObjectValue *root = chain->document()->bind()->rootObjectValue();
-        if (root->lookupMember(_name, _scopeChain.context())) {
+        if (root && root->lookupMember(_name, _scopeChain.context())) {
             return check(root);
         }
 

From 1166dcd441cff1228689494be68f273ede763dc3 Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@nokia.com>
Date: Fri, 2 Dec 2011 11:24:39 +0100
Subject: [PATCH 06/14] SSH: Ask for private key password right on connection
 start.

This prevents event loop issues (e.g. connection timeout).

Task-number: QTCREATORBUG-6641
Change-Id: Ibeecaac2621e171a0590621fd9fdde8f7e3ab9c5
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
---
 src/libs/utils/ssh/sshconnection.cpp | 35 ++++++++++++++++++++++------
 src/libs/utils/ssh/sshconnection_p.h |  1 +
 2 files changed, 29 insertions(+), 7 deletions(-)

diff --git a/src/libs/utils/ssh/sshconnection.cpp b/src/libs/utils/ssh/sshconnection.cpp
index 647a3d26be4..cd5d552349b 100644
--- a/src/libs/utils/ssh/sshconnection.cpp
+++ b/src/libs/utils/ssh/sshconnection.cpp
@@ -453,12 +453,6 @@ void SshConnectionPrivate::handleServiceAcceptPacket()
         m_sendFacility.sendUserAuthByPwdRequestPacket(m_connParams.userName.toUtf8(),
             SshCapabilities::SshConnectionService, m_connParams.password.toUtf8());
     } else {
-        Utils::FileReader reader;
-        if (!reader.fetch(m_connParams.privateKeyFile))
-            throw SshClientException(SshKeyFileError,
-                tr("Private key error: %1").arg(reader.errorString()));
-
-        m_sendFacility.createAuthenticationKey(reader.data());
         m_sendFacility.sendUserAuthByKeyRequestPacket(m_connParams.userName.toUtf8(),
             SshCapabilities::SshConnectionService);
     }
@@ -637,6 +631,22 @@ void SshConnectionPrivate::connectToHost()
     m_error = SshNoError;
     m_ignoreNextPacket = false;
     m_errorString.clear();
+
+    try {
+        if (m_connParams.authenticationType == SshConnectionParameters::AuthenticationByKey)
+            createPrivateKey();
+    } catch (const SshClientException &ex) {
+        m_error = ex.error;
+        m_errorString = ex.errorString;
+        emit error(m_error);
+        return;
+    } catch (const Botan::Exception &ex) {
+        m_error = SshKeyFileError;
+        m_errorString = QString::fromAscii(ex.what());
+        emit error(m_error);
+        return;
+    }
+
     connect(m_socket, SIGNAL(connected()), this, SLOT(handleSocketConnected()));
     connect(m_socket, SIGNAL(readyRead()), this, SLOT(handleIncomingData()));
     connect(m_socket, SIGNAL(error(QAbstractSocket::SocketError)), this,
@@ -681,7 +691,18 @@ void SshConnectionPrivate::closeConnection(SshErrorCode sshError,
 bool SshConnectionPrivate::canUseSocket() const
 {
     return m_socket->isValid()
-        && m_socket->state() == QAbstractSocket::ConnectedState;
+            && m_socket->state() == QAbstractSocket::ConnectedState;
+}
+
+void SshConnectionPrivate::createPrivateKey()
+{
+    Utils::FileReader reader;
+    if (m_connParams.privateKeyFile.isEmpty())
+        throw SshClientException(SshKeyFileError, tr("No private key file given."));
+    if (!reader.fetch(m_connParams.privateKeyFile))
+        throw SshClientException(SshKeyFileError,
+            tr("Private key file error: %1").arg(reader.errorString()));
+    m_sendFacility.createAuthenticationKey(reader.data());
 }
 
 QSharedPointer<SshRemoteProcess> SshConnectionPrivate::createRemoteProcess(const QByteArray &command)
diff --git a/src/libs/utils/ssh/sshconnection_p.h b/src/libs/utils/ssh/sshconnection_p.h
index 45f1ea03b07..d02cdcb1771 100644
--- a/src/libs/utils/ssh/sshconnection_p.h
+++ b/src/libs/utils/ssh/sshconnection_p.h
@@ -137,6 +137,7 @@ private:
     void handleChannelClose();
     void handleDisconnect();
     bool canUseSocket() const;
+    void createPrivateKey();
 
     void sendData(const QByteArray &data);
 

From 0bec54d1809affe75f8eaf21160e88b3ba983396 Mon Sep 17 00:00:00 2001
From: Daniel Teske <daniel.teske@nokia.com>
Date: Fri, 2 Dec 2011 14:56:00 +0100
Subject: [PATCH 07/14] Fix crash in submit editor
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Task-number: QTCREATORBUG-6657

Change-Id: I1b7b9f6e84b4e81ed1c81c70c9a0b4e3dce360e3
Reviewed-by: Friedemann Kleint <Friedemann.Kleint@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
Reviewed-by: Robert Löhning <robert.loehning@nokia.com>
---
 src/libs/utils/submiteditorwidget.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libs/utils/submiteditorwidget.cpp b/src/libs/utils/submiteditorwidget.cpp
index 44aeaa967ff..4a7fafd9d2c 100644
--- a/src/libs/utils/submiteditorwidget.cpp
+++ b/src/libs/utils/submiteditorwidget.cpp
@@ -323,7 +323,7 @@ static QString wrappedText(const QTextEdit *e)
         rc += cursor.selectedText();
         rc += newLine;
         cursor.movePosition(QTextCursor::EndOfLine); // Mac needs it
-        cursor.movePosition(QTextCursor::Right);
+        cursor.movePosition(QTextCursor::NextCharacter);
     }
     return rc;
 }

From 0a59f347946a44583dc4f6271bbfa93b481d84dd Mon Sep 17 00:00:00 2001
From: Christian Kandeler <christian.kandeler@nokia.com>
Date: Mon, 5 Dec 2011 15:48:14 +0100
Subject: [PATCH 08/14] Harmattan: Introduce new condition for auto-generation
 of manifest file.

In addition to using an empty file as in 2.3, the user can now also put
a magic string at the start of the manifest file. This way, we can use
this as the default while also documenting it in-place.

Task-number: https://projects.maemo.org/bugzilla/show_bug.cgi?id=284797
Change-Id: I375a73a5d2e9d3e0973d97d81e0110e788d0159a
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
---
 share/qtcreator/templates/shared/manifest.aegis |  6 +++---
 src/plugins/madde/maemopackagecreationstep.cpp  | 11 ++++-------
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/share/qtcreator/templates/shared/manifest.aegis b/share/qtcreator/templates/shared/manifest.aegis
index e584f96161e..c0d0dd9c4ce 100644
--- a/share/qtcreator/templates/shared/manifest.aegis
+++ b/share/qtcreator/templates/shared/manifest.aegis
@@ -1,3 +1,4 @@
+AutoGenerateAegisFile
 <!-- Aegis manifest declares the security credentials required by an
      application to run correctly. By default, a manifest file will be
      created or updated automatically as a part of build.
@@ -9,9 +10,8 @@
 
      To create a manifest file automatically as a part of build (DEFAULT):
 
-      * You may leave this file as-is.
-      * Do not list any '<credential name="token" />' entries
-        outside of comments.
+      * Make sure this file starts with the string "AutoGenerateAegisFile" (without quotes).
+      * Alternatively, it can also be completely empty.
 
      To provide a manifest yourself:
 
diff --git a/src/plugins/madde/maemopackagecreationstep.cpp b/src/plugins/madde/maemopackagecreationstep.cpp
index 25e22da4f48..f95a0789e04 100644
--- a/src/plugins/madde/maemopackagecreationstep.cpp
+++ b/src/plugins/madde/maemopackagecreationstep.cpp
@@ -370,14 +370,8 @@ bool MaemoDebianPackageCreationStep::copyDebianFiles(bool inSourceBuild)
     foreach (const QString &fileName, files) {
         const QString srcFile = templatesDirPath + QLatin1Char('/') + fileName;
         QString newFileName = fileName;
-        if (newFileName == Qt4HarmattanTarget::aegisManifestFileName()) {
-            // If the user has touched the Aegis manifest file, we copy it for use
-            // by MADDE. Otherwise the required capabilities will be auto-detected,
-            // unless the user explicitly requests that no manifest should be created.
-            if (QFileInfo(srcFile).size() == 0)
-                continue;
+        if (newFileName == Qt4HarmattanTarget::aegisManifestFileName())
             newFileName = maemoTarget()->packageName() + QLatin1String(".aegis");
-        }
 
         const QString destFile = debianDirPath + QLatin1Char('/') + newFileName;
         if (fileName == QLatin1String("rules")) {
@@ -393,6 +387,9 @@ bool MaemoDebianPackageCreationStep::copyDebianFiles(bool inSourceBuild)
                     .arg(QDir::toNativeSeparators(srcFile), reader.errorString()));
                 return false;
             }
+
+            if (reader.data().isEmpty() || reader.data().startsWith("AutoGenerateAegisFile"))
+                continue;
             if (reader.data().startsWith("NoAegisFile")) {
                 QFile targetFile(destFile);
                 if (!targetFile.open(QIODevice::WriteOnly)) {

From c1f643e387788f905f5f8b0466c70ccebb9bc58e Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@nokia.com>
Date: Mon, 5 Dec 2011 15:48:37 +0100
Subject: [PATCH 09/14] Fix search next/prev in search results.

Broke with ebb9e252779aff1ff874565c2b056f1c8319c2c8

Change-Id: Ifb5821d4712e780df70bc1ec798123dd7b63b108
Reviewed-by: Jarek Kobus <jaroslaw.kobus@nokia.com>
---
 src/plugins/find/searchresulttreemodel.cpp | 27 ++++++++++++++--------
 src/plugins/find/searchresulttreemodel.h   |  6 +++--
 src/plugins/find/searchresultwidget.cpp    |  9 +++++---
 3 files changed, 27 insertions(+), 15 deletions(-)

diff --git a/src/plugins/find/searchresulttreemodel.cpp b/src/plugins/find/searchresulttreemodel.cpp
index 95336e8a563..dc7f3699562 100644
--- a/src/plugins/find/searchresulttreemodel.cpp
+++ b/src/plugins/find/searchresulttreemodel.cpp
@@ -492,6 +492,13 @@ QModelIndex SearchResultTreeModel::prevIndex(const QModelIndex &idx, bool *wrapp
     return current;
 }
 
+QModelIndex SearchResultTreeModel::followingIndex(const QModelIndex &idx, bool backward, bool includeGenerated, bool *wrapped)
+{
+    if (backward)
+        return prev(idx, includeGenerated, wrapped);
+    return next(idx, includeGenerated, wrapped);
+}
+
 QModelIndex SearchResultTreeModel::prev(const QModelIndex &idx, bool includeGenerated, bool *wrapped) const
 {
     QModelIndex value = idx;
@@ -502,7 +509,8 @@ QModelIndex SearchResultTreeModel::prev(const QModelIndex &idx, bool includeGene
 }
 
 QModelIndex SearchResultTreeModel::find(const QRegExp &expr, const QModelIndex &index,
-                                        QTextDocument::FindFlags flags, bool *wrapped)
+                                        QTextDocument::FindFlags flags,
+                                        bool startWithCurrentIndex, bool *wrapped)
 {
     QModelIndex resultIndex;
     QModelIndex currentIndex = index;
@@ -512,6 +520,8 @@ QModelIndex SearchResultTreeModel::find(const QRegExp &expr, const QModelIndex &
     bool anyWrapped = false;
     bool stepWrapped = false;
 
+    if (!startWithCurrentIndex)
+        currentIndex = followingIndex(currentIndex, backward, true, &stepWrapped);
     do {
         anyWrapped |= stepWrapped; // update wrapped state if we actually stepped to next/prev item
         if (currentIndex.isValid()) {
@@ -519,10 +529,7 @@ QModelIndex SearchResultTreeModel::find(const QRegExp &expr, const QModelIndex &
             if (expr.indexIn(text) != -1)
                 resultIndex = currentIndex;
         }
-        if (backward)
-            currentIndex = prev(currentIndex, true, &stepWrapped);
-        else
-            currentIndex = next(currentIndex, true, &stepWrapped);
+        currentIndex = followingIndex(currentIndex, backward, true, &stepWrapped);
     } while (!resultIndex.isValid() && currentIndex.isValid() && currentIndex != index);
     if (resultIndex.isValid() && wrapped)
         *wrapped = anyWrapped;
@@ -530,7 +537,8 @@ QModelIndex SearchResultTreeModel::find(const QRegExp &expr, const QModelIndex &
 }
 
 QModelIndex SearchResultTreeModel::find(const QString &term, const QModelIndex &index,
-                                        QTextDocument::FindFlags flags, bool *wrapped)
+                                        QTextDocument::FindFlags flags,
+                                        bool startWithCurrentIndex, bool *wrapped)
 {
     QModelIndex resultIndex;
     QModelIndex currentIndex = index;
@@ -541,6 +549,8 @@ QModelIndex SearchResultTreeModel::find(const QString &term, const QModelIndex &
     bool anyWrapped = false;
     bool stepWrapped = false;
 
+    if (!startWithCurrentIndex)
+        currentIndex = followingIndex(currentIndex, backward, true, &stepWrapped);
     do {
         anyWrapped |= stepWrapped; // update wrapped state if we actually stepped to next/prev item
         if (currentIndex.isValid()) {
@@ -549,10 +559,7 @@ QModelIndex SearchResultTreeModel::find(const QString &term, const QModelIndex &
             if (!doc.find(term, 0, flags).isNull())
                 resultIndex = currentIndex;
         }
-        if (backward)
-            currentIndex = prev(currentIndex, true, &stepWrapped);
-        else
-            currentIndex = next(currentIndex, true, &stepWrapped);
+        currentIndex = followingIndex(currentIndex, backward, true, &stepWrapped);
     } while (!resultIndex.isValid() && currentIndex.isValid() && currentIndex != index);
     if (resultIndex.isValid() && wrapped)
         *wrapped = anyWrapped;
diff --git a/src/plugins/find/searchresulttreemodel.h b/src/plugins/find/searchresulttreemodel.h
index 40c2d789a1c..e01a869785c 100644
--- a/src/plugins/find/searchresulttreemodel.h
+++ b/src/plugins/find/searchresulttreemodel.h
@@ -71,9 +71,9 @@ public:
     QList<QModelIndex> addResults(const QList<SearchResultItem> &items, SearchResult::AddMode mode);
 
     QModelIndex find(const QRegExp &expr, const QModelIndex &index,
-                     QTextDocument::FindFlags flags, bool *wrapped = 0);
+                     QTextDocument::FindFlags flags, bool startWithCurrentIndex, bool *wrapped = 0);
     QModelIndex find(const QString &term, const QModelIndex &index,
-                     QTextDocument::FindFlags flags, bool *wrapped = 0);
+                     QTextDocument::FindFlags flags, bool startWithCurrentIndex, bool *wrapped = 0);
 
 signals:
     void jumpToSearchResult(const QString &fileName, int lineNumber,
@@ -90,6 +90,8 @@ private:
     bool setCheckState(const QModelIndex &idx, Qt::CheckState checkState, bool firstCall = true);
     QModelIndex nextIndex(const QModelIndex &idx, bool *wrapped = 0) const;
     QModelIndex prevIndex(const QModelIndex &idx, bool *wrapped = 0) const;
+    QModelIndex followingIndex(const QModelIndex &idx, bool backward, bool includeGenerated = false,
+                               bool *wrapped = 0);
     SearchResultTreeItem *treeItemAtIndex(const QModelIndex &idx) const;
 
     SearchResultTreeItem *m_rootItem;
diff --git a/src/plugins/find/searchresultwidget.cpp b/src/plugins/find/searchresultwidget.cpp
index 34205ef4c7a..556bd2409b5 100644
--- a/src/plugins/find/searchresultwidget.cpp
+++ b/src/plugins/find/searchresultwidget.cpp
@@ -117,7 +117,7 @@ public:
         }
         m_view->setCurrentIndex(m_incrementalFindStart);
         bool wrapped = false;
-        IFindSupport::Result result = find(txt, findFlags, &wrapped);
+        IFindSupport::Result result = find(txt, findFlags, true/*startFromCurrent*/, &wrapped);
         if (wrapped != m_incrementalWrappedState) {
             m_incrementalWrappedState = wrapped;
             showWrapIndicator(m_view);
@@ -128,7 +128,7 @@ public:
     IFindSupport::Result findStep(const QString &txt, Find::FindFlags findFlags)
     {
         bool wrapped = false;
-        IFindSupport::Result result = find(txt, findFlags, &wrapped);
+        IFindSupport::Result result = find(txt, findFlags, false/*startFromNext*/, &wrapped);
         if (wrapped)
             showWrapIndicator(m_view);
         if (result == IFindSupport::Found) {
@@ -138,7 +138,8 @@ public:
         return result;
     }
 
-    IFindSupport::Result find(const QString &txt, Find::FindFlags findFlags, bool *wrapped)
+    IFindSupport::Result find(const QString &txt, Find::FindFlags findFlags,
+                              bool startFromCurrentIndex, bool *wrapped)
     {
         if (wrapped)
             *wrapped = false;
@@ -150,11 +151,13 @@ public:
             index = m_view->model()->find(QRegExp(txt, (sensitive ? Qt::CaseSensitive : Qt::CaseInsensitive)),
                                           m_view->currentIndex(),
                                           Find::textDocumentFlagsForFindFlags(findFlags),
+                                          startFromCurrentIndex,
                                           wrapped);
         } else {
             index = m_view->model()->find(txt,
                                           m_view->currentIndex(),
                                           Find::textDocumentFlagsForFindFlags(findFlags),
+                                          startFromCurrentIndex,
                                           wrapped);
         }
         if (index.isValid()) {

From 6e6c9f9884d30b7f94dd45a9665dbcc9cad43f6b Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@nokia.com>
Date: Mon, 5 Dec 2011 17:05:08 +0100
Subject: [PATCH 10/14] Don't try finalizing files that were never created.

Task-number: QTCREATORBUG-6643

Change-Id: I04945ebb39caace476a12f293666cfcec0f8a9e5
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
---
 src/libs/utils/savefile.cpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/libs/utils/savefile.cpp b/src/libs/utils/savefile.cpp
index b844e3b6c72..a37633db9f2 100644
--- a/src/libs/utils/savefile.cpp
+++ b/src/libs/utils/savefile.cpp
@@ -37,7 +37,7 @@
 namespace Utils {
 
 SaveFile::SaveFile(const QString &filename) :
-    m_finalFileName(filename), m_finalized(false), m_backup(false)
+    m_finalFileName(filename), m_finalized(true), m_backup(false)
 {
 }
 
@@ -62,6 +62,7 @@ bool SaveFile::open(OpenMode flags)
     if (!QTemporaryFile::open(flags))
         return false;
 
+    m_finalized = false; // needs clean up in the end
     if (ofi.exists())
         setPermissions(ofi.permissions()); // Ignore errors
 

From c979f46e2e5a02befd30f9490412e0d55e7c65fa Mon Sep 17 00:00:00 2001
From: Sergey Belyashov <Sergey.Belyashov@gmail.com>
Date: Fri, 2 Dec 2011 22:00:47 +0400
Subject: [PATCH 11/14] Russian translation update

Change-Id: Ib31f661cc50a5126cb67b628708965142da74bfb
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
---
 share/qtcreator/translations/qtcreator_ru.ts | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/share/qtcreator/translations/qtcreator_ru.ts b/share/qtcreator/translations/qtcreator_ru.ts
index abeb91a3442..c03d2e38e9f 100644
--- a/share/qtcreator/translations/qtcreator_ru.ts
+++ b/share/qtcreator/translations/qtcreator_ru.ts
@@ -19409,6 +19409,10 @@ Error: %2</source>
         <source>Qt</source>
         <translation>Qt</translation>
     </message>
+    <message>
+        <source>Old Creator</source>
+        <translation>Старый Creator</translation>
+    </message>
 </context>
 <context>
     <name>QmlJsDebugClient::QmlProfilerEventList</name>
@@ -27127,10 +27131,6 @@ Influences the indentation of continuation lines.
         <source>Unexpected packet of type %1.</source>
         <translation>Неожиданный пакет типа %1.</translation>
     </message>
-    <message>
-        <source>Private key error: %1</source>
-        <translation>Ошибка закрытого ключа: %1</translation>
-    </message>
     <message>
         <source>Password expired.</source>
         <translation>Время действия пароля истекло.</translation>
@@ -27159,6 +27159,14 @@ Influences the indentation of continuation lines.
         <source>Timeout waiting for reply from server.</source>
         <translation>Вышло время ожидания ответа от сервера.</translation>
     </message>
+    <message>
+        <source>No private key file given.</source>
+        <translation>Не задан файл закрытого ключа.</translation>
+    </message>
+    <message>
+        <source>Private key file error: %1</source>
+        <translation>Ошибка файла закрытого ключа: %1</translation>
+    </message>
 </context>
 <context>
     <name>Utils::IpAddressLineEdit</name>

From a1b2fc95f3145e641e421205bfec38f351f16d97 Mon Sep 17 00:00:00 2001
From: Robert Loehning <robert.loehning@nokia.com>
Date: Tue, 6 Dec 2011 14:35:18 +0100
Subject: [PATCH 12/14] Added German translations for late patches

Change-Id: I87ce2a9c0cb8452c9e5850ae75cc0dc057f5e016
Reviewed-by: Christian Kandeler <christian.kandeler@nokia.com>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@nokia.com>
---
 share/qtcreator/translations/qtcreator_de.ts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/share/qtcreator/translations/qtcreator_de.ts b/share/qtcreator/translations/qtcreator_de.ts
index 561d3c36123..ebb5300cadc 100644
--- a/share/qtcreator/translations/qtcreator_de.ts
+++ b/share/qtcreator/translations/qtcreator_de.ts
@@ -20698,6 +20698,14 @@ Sie können diese Anwendung sowohl auf Desktop- als auch auf mobilen Plattformen
         <source>Timeout waiting for reply from server.</source>
         <translation>Überschreitung des Zeitlimits beim Warten auf Antwort vom Server.</translation>
     </message>
+    <message>
+        <source>No private key file given.</source>
+        <translation>Keine Datei mit privatem Schlüssel angegeben.</translation>
+    </message>
+    <message>
+        <source>Private key file error: %1</source>
+        <translation>Problem mit privatem Schlüssel: %1</translation>
+    </message>
 </context>
 <context>
     <name>Qt4ProjectManager::Internal::SubdirsProjectWizardDialog</name>
@@ -24590,6 +24598,10 @@ Sollen sie überschrieben werden?</translation>
         <source>Qt</source>
         <translation>Qt</translation>
     </message>
+    <message>
+        <source>Old Creator</source>
+        <translation>Veraltete Creator-Konvention</translation>
+    </message>
 </context>
 <context>
     <name>QmlProfiler::Internal::QmlProfilerEngine</name>

From 0840b93ff5cc03df9521ef23ab9ac0b0d0ec9339 Mon Sep 17 00:00:00 2001
From: Tobias Hunger <tobias.hunger@nokia.com>
Date: Tue, 6 Dec 2011 15:23:46 +0100
Subject: [PATCH 13/14] Fix possible crash in environmentsmodel

Change-Id: Ib6a3450a7974dc568ba07633a38a29d598a9099f
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
---
 src/libs/utils/environmentmodel.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libs/utils/environmentmodel.cpp b/src/libs/utils/environmentmodel.cpp
index 616feddc4a0..14b8a4ac5a1 100644
--- a/src/libs/utils/environmentmodel.cpp
+++ b/src/libs/utils/environmentmodel.cpp
@@ -211,7 +211,7 @@ bool EnvironmentModel::setData(const QModelIndex &index, const QVariant &value,
         const QString &newName = value.toString();
 #endif
         // Does the new name exist already?
-        if (d->m_resultEnvironment.hasKey(newName))
+        if (d->m_resultEnvironment.hasKey(newName) || newName.isEmpty())
             return false;
 
         Utils::EnvironmentItem newVariable(newName, oldValue);
@@ -227,7 +227,7 @@ bool EnvironmentModel::setData(const QModelIndex &index, const QVariant &value,
         const QString stringValue = value.toString();
         if (changesPos != -1) {
             // We have already changed this value
-            if (stringValue == d->m_baseEnvironment.value(oldName)) {
+            if (d->m_baseEnvironment.hasKey(oldName) && stringValue == d->m_baseEnvironment.value(oldName)) {
                 // ... and now went back to the base value
                 d->m_items.removeAt(changesPos);
             } else {

From b0b0842b03320d03d335ee40d361d774e93ee2f4 Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@nokia.com>
Date: Tue, 6 Dec 2011 16:57:09 +0100
Subject: [PATCH 14/14] Fix the height of the new search result pane.

For the bigger search filters like C++ Symbols & Files on File System
it was unusable e.g. on Mac.

Change-Id: I1839238660cc7508ada4e580388ee08d8eca8a6a
Reviewed-by: Daniel Teske <daniel.teske@nokia.com>
Reviewed-by: Eike Ziller <eike.ziller@nokia.com>
---
 src/plugins/find/finddialog.ui          | 150 +++++++++++-------------
 src/plugins/find/findtoolwindow.cpp     |  14 +++
 src/plugins/find/searchresultwindow.cpp |  26 +++-
 3 files changed, 107 insertions(+), 83 deletions(-)

diff --git a/src/plugins/find/finddialog.ui b/src/plugins/find/finddialog.ui
index 4a57a70787f..d77ad32132a 100644
--- a/src/plugins/find/finddialog.ui
+++ b/src/plugins/find/finddialog.ui
@@ -7,7 +7,7 @@
     <x>0</x>
     <y>0</y>
     <width>673</width>
-    <height>210</height>
+    <height>240</height>
    </rect>
   </property>
   <property name="maximumSize">
@@ -17,28 +17,53 @@
    </size>
   </property>
   <layout class="QGridLayout" name="gridLayout">
-   <item row="0" column="0">
-    <widget class="QLabel" name="label">
-     <property name="sizePolicy">
-      <sizepolicy hsizetype="Fixed" vsizetype="Preferred">
-       <horstretch>0</horstretch>
-       <verstretch>0</verstretch>
-      </sizepolicy>
-     </property>
-     <property name="minimumSize">
-      <size>
-       <width>80</width>
-       <height>0</height>
-      </size>
-     </property>
+   <property name="sizeConstraint">
+    <enum>QLayout::SetFixedSize</enum>
+   </property>
+   <item row="4" column="0" colspan="2">
+    <layout class="QHBoxLayout" name="horizontalLayout_3">
+     <item>
+      <spacer name="horizontalSpacer_3">
+       <property name="orientation">
+        <enum>Qt::Horizontal</enum>
+       </property>
+       <property name="sizeHint" stdset="0">
+        <size>
+         <width>40</width>
+         <height>20</height>
+        </size>
+       </property>
+      </spacer>
+     </item>
+     <item>
+      <widget class="QPushButton" name="searchButton">
+       <property name="text">
+        <string>&amp;Search</string>
+       </property>
+       <property name="default">
+        <bool>true</bool>
+       </property>
+      </widget>
+     </item>
+     <item>
+      <widget class="QPushButton" name="replaceButton">
+       <property name="text">
+        <string>Search &amp;&amp; &amp;Replace</string>
+       </property>
+      </widget>
+     </item>
+    </layout>
+   </item>
+   <item row="1" column="0">
+    <widget class="QLabel" name="label_2">
      <property name="text">
-      <string>Sco&amp;pe:</string>
+      <string>Sear&amp;ch for:</string>
      </property>
      <property name="alignment">
       <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
      </property>
      <property name="buddy">
-      <cstring>filterList</cstring>
+      <cstring>searchTerm</cstring>
      </property>
     </widget>
    </item>
@@ -77,22 +102,6 @@
      </layout>
     </widget>
    </item>
-   <item row="1" column="0">
-    <widget class="QLabel" name="label_2">
-     <property name="text">
-      <string>Sear&amp;ch for:</string>
-     </property>
-     <property name="alignment">
-      <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
-     </property>
-     <property name="buddy">
-      <cstring>searchTerm</cstring>
-     </property>
-    </widget>
-   </item>
-   <item row="1" column="1">
-    <widget class="QLineEdit" name="searchTerm"/>
-   </item>
    <item row="2" column="1">
     <widget class="QWidget" name="widget" native="true">
      <layout class="QHBoxLayout" name="horizontalLayout">
@@ -136,6 +145,34 @@
      </layout>
     </widget>
    </item>
+   <item row="0" column="0">
+    <widget class="QLabel" name="label">
+     <property name="sizePolicy">
+      <sizepolicy hsizetype="Fixed" vsizetype="Preferred">
+       <horstretch>0</horstretch>
+       <verstretch>0</verstretch>
+      </sizepolicy>
+     </property>
+     <property name="minimumSize">
+      <size>
+       <width>80</width>
+       <height>0</height>
+      </size>
+     </property>
+     <property name="text">
+      <string>Sco&amp;pe:</string>
+     </property>
+     <property name="alignment">
+      <set>Qt::AlignRight|Qt::AlignTrailing|Qt::AlignVCenter</set>
+     </property>
+     <property name="buddy">
+      <cstring>filterList</cstring>
+     </property>
+    </widget>
+   </item>
+   <item row="1" column="1">
+    <widget class="QLineEdit" name="searchTerm"/>
+   </item>
    <item row="3" column="0" colspan="2">
     <widget class="QWidget" name="configWidget" native="true">
      <property name="sizePolicy">
@@ -146,53 +183,6 @@
      </property>
     </widget>
    </item>
-   <item row="4" column="0" colspan="2">
-    <layout class="QHBoxLayout" name="horizontalLayout_3">
-     <item>
-      <spacer name="horizontalSpacer_3">
-       <property name="orientation">
-        <enum>Qt::Horizontal</enum>
-       </property>
-       <property name="sizeHint" stdset="0">
-        <size>
-         <width>40</width>
-         <height>20</height>
-        </size>
-       </property>
-      </spacer>
-     </item>
-     <item>
-      <widget class="QPushButton" name="searchButton">
-       <property name="text">
-        <string>&amp;Search</string>
-       </property>
-       <property name="default">
-        <bool>true</bool>
-       </property>
-      </widget>
-     </item>
-     <item>
-      <widget class="QPushButton" name="replaceButton">
-       <property name="text">
-        <string>Search &amp;&amp; &amp;Replace</string>
-       </property>
-      </widget>
-     </item>
-    </layout>
-   </item>
-   <item row="5" column="1">
-    <spacer name="verticalSpacer">
-     <property name="orientation">
-      <enum>Qt::Vertical</enum>
-     </property>
-     <property name="sizeHint" stdset="0">
-      <size>
-       <width>20</width>
-       <height>40</height>
-      </size>
-     </property>
-    </spacer>
-   </item>
   </layout>
  </widget>
  <tabstops>
diff --git a/src/plugins/find/findtoolwindow.cpp b/src/plugins/find/findtoolwindow.cpp
index f2c284a1652..1aecc9f9751 100644
--- a/src/plugins/find/findtoolwindow.cpp
+++ b/src/plugins/find/findtoolwindow.cpp
@@ -40,6 +40,7 @@
 #include <QtGui/QStringListModel>
 #include <QtGui/QCompleter>
 #include <QtGui/QKeyEvent>
+#include <QtGui/QScrollArea>
 
 using namespace Find;
 using namespace Find::Internal;
@@ -186,6 +187,19 @@ void FindToolWindow::setCurrentFilter(int index)
                 configWidget->setParent(0);
         }
     }
+    QWidget *w = m_ui.configWidget;
+    while (w) {
+        QScrollArea *sa = qobject_cast<QScrollArea *>(w);
+        if (sa) {
+            sa->updateGeometry();
+            break;
+        }
+        w = w->parentWidget();
+    }
+    for (w = m_configWidget ? m_configWidget : m_ui.configWidget; w; w = w->parentWidget()) {
+        if (w->layout())
+            w->layout()->activate();
+    }
 }
 
 void FindToolWindow::acceptAndGetParameters(QString *term, IFindFilter **filter)
diff --git a/src/plugins/find/searchresultwindow.cpp b/src/plugins/find/searchresultwindow.cpp
index aed3329cfcc..37ddce4371d 100644
--- a/src/plugins/find/searchresultwindow.cpp
+++ b/src/plugins/find/searchresultwindow.cpp
@@ -58,7 +58,28 @@ namespace Find {
 
 namespace Internal {
 
-    class SearchResultWindowPrivate : public QObject {
+    class InternalScrollArea : public QScrollArea
+    {
+        Q_OBJECT
+    public:
+        explicit InternalScrollArea(QWidget *parent)
+            : QScrollArea(parent)
+        {
+            setFrameStyle(QFrame::NoFrame);
+            setVerticalScrollBarPolicy(Qt::ScrollBarAsNeeded);
+            setHorizontalScrollBarPolicy(Qt::ScrollBarAsNeeded);
+        }
+
+        QSize sizeHint() const
+        {
+            if (widget())
+                return widget()->size();
+            return QScrollArea::sizeHint();
+        }
+    };
+
+    class SearchResultWindowPrivate : public QObject
+    {
         Q_OBJECT
     public:
         SearchResultWindowPrivate(SearchResultWindow *window);
@@ -210,8 +231,7 @@ SearchResultWindow::SearchResultWindow(QWidget *newSearchPanel)
     d->m_widget = new QStackedWidget;
     d->m_widget->setWindowTitle(displayName());
 
-    QScrollArea *newSearchArea = new QScrollArea(d->m_widget);
-    newSearchArea->setFrameStyle(QFrame::NoFrame);
+    InternalScrollArea *newSearchArea = new InternalScrollArea(d->m_widget);
     newSearchArea->setWidget(newSearchPanel);
     newSearchArea->setFocusProxy(newSearchPanel);
     d->m_widget->addWidget(newSearchArea);