feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Axivion: Pass arg by const reference

Browse Source 
Amends 0b0941cbcb

Change-Id: I61cfe511be6627a347b330a6833f5d7a4afe3f1d
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
Jarek Kobus
2024-03-11 14:56:10 +01:00
parent cd4ec16f6e
commit d30f97ac7e
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/axivion/axivionoutputpane.cpp
View File

@@ -269,7 +269,7 @@ private:
void updateTable(); void updateTable();
void addIssues(const Dto::IssueTableDto &dto, int startRow); void addIssues(const Dto::IssueTableDto &dto, int startRow);
void onSearchParameterChanged(); void onSearchParameterChanged();
void updateBasicProjectInfo(std::optional<Dto::ProjectInfoDto> info); void updateBasicProjectInfo(const std::optional<Dto::ProjectInfoDto> &info);
void setFiltersEnabled(bool enabled); void setFiltersEnabled(bool enabled);
void fetchTable(); void fetchTable();
void fetchIssues(const IssueListSearch &search); void fetchIssues(const IssueListSearch &search);
@@ -375,7 +375,7 @@ IssuesWidget::IssuesWidget(QWidget *parent)
void IssuesWidget::updateUi() void IssuesWidget::updateUi()
{ {
setFiltersEnabled(false); setFiltersEnabled(false);
std::optional<Dto::ProjectInfoDto> projectInfo = Internal::projectInfo(); const std::optional<Dto::ProjectInfoDto> projectInfo = Internal::projectInfo();
updateBasicProjectInfo(projectInfo); updateBasicProjectInfo(projectInfo);
if (!projectInfo) if (!projectInfo)
@@ -535,7 +535,7 @@ void IssuesWidget::onSearchParameterChanged()
fetchIssues(search); fetchIssues(search);
} }
void IssuesWidget::updateBasicProjectInfo(std::optional<Dto::ProjectInfoDto> info) void IssuesWidget::updateBasicProjectInfo(const std::optional<Dto::ProjectInfoDto> &info)
{ {
auto cleanOld = [this] { auto cleanOld = [this] {
const QList<QAbstractButton *> originalList = m_typesButtonGroup->buttons(); const QList<QAbstractButton *> originalList = m_typesButtonGroup->buttons();