feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Git: Branchmodel: Fix fetching all remotes at once

Browse Source 
We want to return an empty string when "Remote Branches"
is selected, instead of an empty optional.

Broken by 224e4eeb59

Change-Id: I5af06fafec48910226fdedf4a15079444cc54b6e
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Andre Hartmann
2024-02-05 13:25:40 +01:00
committed by André Hartmann
parent 78d42d2d54
commit d3385ebb65
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/git/branchmodel.cpp
View File

@@ -757,7 +757,7 @@ std::optional<QString> BranchModel::remoteName(const QModelIndex &idx) const
if (!node)
return std::nullopt;
if (node == remotesNode)
return {};
return QString(); // keep QString() as {} might convert to std::nullopt
if (node->parent == remotesNode)
return node->name;
return std::nullopt;