Clean exported headers of the VcsBase plugin.

Change-Id: Ibfe20bc7156e14e33fd0448586f5cc625494e008
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/bazaar/bazaarclient.cpp

@@ -30,6 +30,8 @@
 #include "bazaarclient.h"
 #include "constants.h"
 
+#include <coreplugin/id.h>
+
 #include <vcsbase/vcsbaseplugin.h>
 #include <vcsbase/vcsoutputwindow.h>
 #include <vcsbase/vcsbaseeditorparameterwidget.h>

src/plugins/bazaar/bazaarcommitwidget.cpp

@@ -32,6 +32,7 @@
 
 #include <texteditor/texteditorsettings.h>
 #include <texteditor/fontsettings.h>
+#include <utils/completingtextedit.h>
 #include <utils/qtcassert.h>
 
 #include <QSyntaxHighlighter>

src/plugins/bazaar/bazaarcontrol.cpp

@@ -32,6 +32,8 @@
 
 #include <vcsbase/vcsbaseconstants.h>
 
+#include <utils/fileutils.h>
+
 #include <QFileInfo>
 #include <QVariant>
 #include <QStringList>

src/plugins/cvs/cvscontrol.cpp

@@ -34,6 +34,8 @@
 
 #include <vcsbase/vcsbaseconstants.h>
 
+#include <utils/fileutils.h>
+
 #include <QFileInfo>
 
 using namespace Cvs;

src/plugins/git/gitsettings.cpp

@@ -30,6 +30,7 @@
 
 #include "gitsettings.h"
 
+#include <utils/fileutils.h>
 #include <utils/hostosinfo.h>
 #include <QCoreApplication>
 

src/plugins/git/gitsubmiteditorwidget.cpp

@@ -33,6 +33,8 @@
 #include "githighlighters.h"
 #include "logchangedialog.h"
 
+#include <utils/completingtextedit.h>
+
 #include <QRegExpValidator>
 #include <QTextEdit>
 

src/plugins/mercurial/mercurialcommitwidget.cpp

@@ -34,6 +34,7 @@
 #include <texteditor/fontsettings.h>
 #include <texteditor/syntaxhighlighter.h>
 #include <texteditor/texteditorconstants.h>
+#include <utils/completingtextedit.h>
 #include <utils/qtcassert.h>
 
 #include <QRegExp>

src/plugins/mercurial/mercurialcontrol.cpp

@@ -36,6 +36,8 @@
 
 #include <coreplugin/vcsmanager.h>
 
+#include <utils/fileutils.h>
+
 #include <QFileInfo>
 #include <QVariant>
 #include <QStringList>

src/plugins/subversion/subversioncontrol.cpp

@@ -34,6 +34,8 @@
 
 #include <vcsbase/vcsbaseconstants.h>
 
+#include <utils/fileutils.h>
+
 #include <QFileInfo>
 
 namespace Subversion {

src/plugins/vcsbase/basecheckoutwizardfactory.h

@@ -34,10 +34,9 @@
 #include "vcsbase_global.h"
 #include <coreplugin/iwizardfactory.h>
 
-#include <utils/fileutils.h>
-
 #include <functional>
 
+namespace Utils { class FileName; }
 namespace VcsBase {
 class BaseCheckoutWizard;
 class VcsCommand;

src/plugins/vcsbase/basevcseditorfactory.h

@@ -32,11 +32,12 @@
 #define BASEVCSEDITORFACTORY_H
 
 #include "vcsbase_global.h"
-#include "vcsbaseeditor.h"
 
 #include <texteditor/texteditor.h>
 
 namespace VcsBase {
+class VcsBaseEditor;
+class VcsBaseEditorParameters;
 
 class VCSBASE_EXPORT VcsEditorFactory : public TextEditor::TextEditorFactory
 {

src/plugins/vcsbase/submiteditorwidget.h

@@ -33,9 +33,6 @@
 
 #include "vcsbase_global.h"
 
-#include <utils/completingtextedit.h>
-
-#include <QWidget>
 #include <QAbstractItemView>
 
 QT_BEGIN_NAMESPACE
@@ -43,6 +40,7 @@ class QAction;
 class QModelIndex;
 QT_END_NAMESPACE
 
+namespace Utils { class CompletingTextEdit; }
 namespace VcsBase {
 
 class SubmitFieldWidget;

src/plugins/vcsbase/vcsbaseclient.h

@@ -32,7 +32,6 @@
 #define VCSBASECLIENT_H
 
 #include "vcsbase_global.h"
-#include <coreplugin/id.h>
 
 #include <QObject>
 #include <QStringList>
@@ -45,6 +44,8 @@ class QVariant;
 class QProcessEnvironment;
 QT_END_NAMESPACE
 
+namespace Core { class Id; }
+
 namespace Utils {
 struct SynchronousProcessResponse;
 class ExitCodeInterpreter;

src/plugins/vcsbase/vcsbaseclientsettings.h

@@ -33,8 +33,6 @@
 
 #include "vcsbase_global.h"
 
-#include <utils/fileutils.h>
-
 #include <QStringList>
 #include <QVariant>
 #include <QSharedDataPointer>
@@ -43,6 +41,7 @@ QT_BEGIN_NAMESPACE
 class QSettings;
 QT_END_NAMESPACE
 
+namespace Utils { class FileName; }
 namespace VcsBase {
 
 namespace Internal { class VcsBaseClientSettingsPrivate; }

src/plugins/vcsbase/vcsbaseplugin.h

@@ -34,7 +34,6 @@
 #include "vcsbase_global.h"
 
 #include <extensionsystem/iplugin.h>
-#include <utils/fileutils.h>
 
 #include <QSharedDataPointer>
 #include <QList>
@@ -45,7 +44,11 @@ class QAction;
 class QTextCodec;
 QT_END_NAMESPACE
 
-namespace Utils { struct SynchronousProcessResponse; }
+namespace Utils
+{
+class FileName;
+struct SynchronousProcessResponse;
+}
 
 namespace Core {
 class Context;

src/plugins/vcsbase/vcsbasesubmiteditor.cpp

@@ -44,6 +44,7 @@
 #include <coreplugin/icore.h>
 #include <coreplugin/editormanager/editormanager.h>
 #include <utils/checkablemessagebox.h>
+#include <utils/completingtextedit.h>
 #include <utils/synchronousprocess.h>
 #include <utils/fileutils.h>
 #include <utils/qtcassert.h>

src/plugins/vcsbase/vcscommand.cpp

@@ -35,6 +35,7 @@
 #include <coreplugin/vcsmanager.h>
 #include <coreplugin/icore.h>
 #include <vcsbase/vcsoutputwindow.h>
+#include <utils/fileutils.h>
 #include <utils/synchronousprocess.h>
 #include <utils/runextensions.h>
 #include <utils/qtcassert.h>

src/plugins/vcsbase/vcscommand.h

@@ -33,9 +33,6 @@
 
 #include "vcsbase_global.h"
 
-#include <utils/fileutils.h>
-#include <utils/synchronousprocess.h>
-
 #include <QObject>
 
 QT_BEGIN_NAMESPACE
@@ -47,6 +44,12 @@ template <typename T>
 class QFutureInterface;
 QT_END_NAMESPACE
 
+namespace Utils {
+struct SynchronousProcessResponse;
+class ExitCodeInterpreter;
+class FileName;
+}
+
 namespace VcsBase {
 
 namespace Internal { class VcsCommandPrivate; }

src/plugins/vcsbase/vcsoutputwindow.h

@@ -35,8 +35,7 @@
 
 #include  <coreplugin/ioutputpane.h>
 
-#include <utils/fileutils.h>
+namespace Utils { class FileName; }
-
 namespace VcsBase {
 
 class VCSBASE_EXPORT VcsOutputWindow : public Core::IOutputPane