feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Drop KitAspect::defaultValue()

Browse Source 
The functionality of this function overlapped with KitAspect::setup(),
leading to unclear responsibilities and resulting in bugs such as the
one fixed by 776d54e435.
Therefore, we drop the defaultValue() function, merging its
implementation with setup() where applicable.

Change-Id: Iefa9c3df8b76e97ddf9ad388516621f7ea6558d4
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Kandeler
2019-03-12 16:50:39 +01:00
parent e80d83cb20
commit d4565be655
17 changed files with 29 additions and 68 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/qbsprojectmanager/qbskitinformation.cpp
View File

@@ -107,7 +107,6 @@ Core::Id QbsKitAspect::id()
return "Qbs.KitInformation";
}
QVariant QbsKitAspect::defaultValue(const Kit *) const { return QString(); }
QList<Task> QbsKitAspect::validate(const Kit *) const { return QList<Task>(); }
KitAspect::ItemList QbsKitAspect::toUserOutput(const Kit *k) const

1
src/plugins/qbsprojectmanager/qbskitinformation.h
View File

@@ -44,7 +44,6 @@ public:
private:
static Core::Id id();
QVariant defaultValue(const ProjectExplorer::Kit *) const override;
QList<ProjectExplorer::Task> validate(const ProjectExplorer::Kit *) const override;
ItemList toUserOutput(const ProjectExplorer::Kit *) const override;
ProjectExplorer::KitAspectWidget *createConfigWidget(ProjectExplorer::Kit *) const override;