feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

PluginSpec: Naming and encapsulation improvements

Browse Source 
Prefer enabled state as a property as opposed to disabled state, and
make setter correspond to getter. Also move setters into private.

Change-Id: I5d002a12f4e540d5b38cc5865490d056ec75f296
Reviewed-by: Daniel Teske <daniel.teske@theqtcompany.com>
This commit is contained in:
Eike Ziller
2015-03-31 09:55:50 +02:00
parent fcc6b11230
commit d456fd0b8a
7 changed files with 72 additions and 64 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/libs/extensionsystem/optionsparser.cpp
View File

@@ -30,6 +30,8 @@
#include "optionsparser.h"
#include "pluginspec_p.h"
#include <QCoreApplication>
using namespace ExtensionSystem;
@@ -151,7 +153,7 @@ bool OptionsParser::checkForLoadOption()
.arg(m_currentArg);
m_hasError = true;
} else {
spec->setForceEnabled(true);
spec->d->setForceEnabled(true);
m_isDependencyRefreshNeeded = true;
}
}
@@ -170,7 +172,7 @@ bool OptionsParser::checkForNoLoadOption()
"The plugin \"%1\" does not exist.").arg(m_currentArg);
m_hasError = true;
} else {
spec->setForceDisabled(true);
spec->d->setForceDisabled(true);
m_isDependencyRefreshNeeded = true;
}
}