ProjectExplorer: Remove pure ProjectConfiguration::isActive function

It's never used polymorphically, and only caused an unused
implementation in BuildStep.

Change-Id: I5fbd34925788ca22960a2f522eef75be3137c67b
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>

src/plugins/projectexplorer/buildconfiguration.h

@@ -103,7 +103,7 @@ public:
 
     static QString buildTypeName(BuildType type);
 
-    bool isActive() const override;
+    bool isActive() const;
 
     static void prependCompilerPathToEnvironment(Kit *k, Utils::Environment &env);
     void updateCacheAndEmitEnvironmentChanged();

src/plugins/projectexplorer/buildstep.cpp

@@ -217,11 +217,6 @@ void BuildStep::reportRunResult(QFutureInterface<bool> &fi, bool success)
     fi.reportFinished();
 }
 
-bool BuildStep::isActive() const
-{
-    return projectConfiguration()->isActive();
-}
-
 bool BuildStep::widgetExpandedByDefault() const
 {
     return m_widgetExpandedByDefault;

src/plugins/projectexplorer/buildstep.h

@@ -87,8 +87,6 @@ public:
 
     static void reportRunResult(QFutureInterface<bool> &fi, bool success);
 
-    bool isActive() const override;
-
     bool widgetExpandedByDefault() const;
     void setWidgetExpandedByDefault(bool widgetExpandedByDefault);
 

src/plugins/projectexplorer/deployconfiguration.h

@@ -56,7 +56,7 @@ public:
     bool fromMap(const QVariantMap &map) override;
     QVariantMap toMap() const override;
 
-    bool isActive() const override;
+    bool isActive() const;
 
     bool usesCustomDeploymentData() const { return m_usesCustomDeploymentData; }
     void setUseCustomDeploymentData(bool enabled) { m_usesCustomDeploymentData = enabled; }

src/plugins/projectexplorer/projectconfiguration.h

@@ -194,8 +194,6 @@ public:
     Target *target() const;
     Project *project() const;
 
-    virtual bool isActive() const = 0;
-
     static QString settingsIdKey();
 
     template<class Aspect, typename ...Args>

src/plugins/projectexplorer/runconfiguration.h

@@ -127,7 +127,7 @@ class PROJECTEXPLORER_EXPORT RunConfiguration : public ProjectConfiguration
 public:
     ~RunConfiguration() override;
 
-    bool isActive() const override;
+    bool isActive() const;
 
     virtual QString disabledReason() const;
     virtual bool isEnabled() const;