feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Clang: Fix splitting flags

Browse Source 
Correct syntax of using regex substitution. The missing
replacement seems to have resulted performing the search
case insensitive which in turn resulted in splitting within
an option. Fix this by explicitly passing an empty
replacement.

Change-Id: Ieccde1f9daae445d0ebe3b7454f56d09f0139e3c
Reviewed-by: Ivan Donchevskii <ivan.donchevskii@qt.io>
Reviewed-by: Oswald Buddenhagen <oswald.buddenhagen@qt.io>
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
Christian Stenger
2018-08-17 10:22:31 +02:00
parent 9e27c865f5
commit d498a7fcf9
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/shared/clang/clang_installation.pri
View File

@@ -93,9 +93,9 @@ defineReplace(splitFlags) {
for (flag, flags_temp) { for (flag, flags_temp) {
equals(inside_quotes, 0) { equals(inside_quotes, 0) {
inside_quotes = 1 inside_quotes = 1
flag ~= s,-I\S*, flag ~= s,-I\S*,,
flag ~= s,/D\S*, flag ~= s,/D\S*,,
flag ~= s,/Z\S*, flag ~= s,/Z\S*,,
result += $$split(flag, " ") result += $$split(flag, " ")
} else { } else {
inside_quotes = 0 inside_quotes = 0