feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

TextEditor: Delete also duplicated assist items

Browse Source 
~GenericProposalModel() did not delete all original items loaded, but the
original items minus the recognized duplicates.

Change-Id: If34f805f8f86391be6e7590e943c1c5adac14869
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: David Schulz <david.schulz@theqtcompany.com>
This commit is contained in:
Nikolai Kosjar
2016-04-26 16:51:53 +02:00
parent 68974f2bd1
commit d545aaee29
1 changed files with 1 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/plugins/texteditor/codeassist/genericproposalmodel.cpp
View File

@@ -179,6 +179,7 @@ void GenericProposalModel::removeDuplicates()
const AssistProposalItemInterface *item = *it; const AssistProposalItemInterface *item = *it;
if (unique.contains(item->text()) if (unique.contains(item->text())
&& unique.value(item->text()) == item->hash()) { && unique.value(item->text()) == item->hash()) {
delete *it;
it = m_originalItems.erase(it); it = m_originalItems.erase(it);
} else { } else {
unique.insert(item->text(), item->hash()); unique.insert(item->text(), item->hash());