feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Remove check if setIdWithoutRefactoring throws

Browse Source 
We don't throw any exception anymore in that case.

Change-Id: I881f22b560081beff6a6275783061228e64cbb28
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Marco Bubke
2022-10-18 16:18:31 +02:00
parent 4e72e0fd27
commit d554bf5e2a
1 changed files with 0 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/auto/qml/qmldesigner/coretests/tst_testcore.cpp
View File

@@ -1757,13 +1757,6 @@ void tst_TestCore::testModelCreateSubNode()
expectedCalls << TestView::MethodCall("nodeIdChanged", QStringList() << "blah" << "blah" << ""); expectedCalls << TestView::MethodCall("nodeIdChanged", QStringList() << "blah" << "blah" << "");
QCOMPARE(view->methodCalls(), expectedCalls); QCOMPARE(view->methodCalls(), expectedCalls);
try {
childNode.setIdWithoutRefactoring("invalid id");
QFAIL("Setting an invalid id does not throw an exception");
} catch (Exception &exception) {
QCOMPARE(exception.type(), QString("InvalidIdException"));
}
QCOMPARE(childNode.id(), QString("blah")); QCOMPARE(childNode.id(), QString("blah"));
QCOMPARE(view->methodCalls(), expectedCalls); QCOMPARE(view->methodCalls(), expectedCalls);