feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

RunConfiguration: Don't call virtual methods by pointer to base method

Browse Source 
Change-Id: Idcd939eff52a9d00addada8ddba0513619b1d432
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Ulf Hermann
2017-05-09 14:19:23 +02:00
parent a6c3b57677
commit d571e8d442
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -672,7 +672,7 @@ void RunControlPrivate::initiateStart()
checkState(State::Initialized);
setState(State::TargetPreparing);
debugMessage("Queue: Prepare target runner");
QTimer::singleShot(0, targetRunner, &TargetRunner::prepare);
QTimer::singleShot(0, targetRunner, [this](){ targetRunner->prepare(); });
}
void RunControlPrivate::onTargetPrepared()
@@ -680,7 +680,7 @@ void RunControlPrivate::onTargetPrepared()
checkState(State::TargetPreparing);
setState(State::ToolPreparing);
debugMessage("Queue: Prepare tool runner");
QTimer::singleShot(0, toolRunner, &ToolRunner::prepare);
QTimer::singleShot(0, toolRunner, [this](){ toolRunner->prepare(); });
}
void RunControlPrivate::onTargetPrepareFailed(const QString &msg)
@@ -696,7 +696,7 @@ void RunControlPrivate::onToolPrepared()
checkState(State::ToolPreparing);
setState(State::TargetStarting);
debugMessage("Queue: Start target runner");
QTimer::singleShot(0, targetRunner, &TargetRunner::start);
QTimer::singleShot(0, targetRunner, [this](){ targetRunner->start(); });
}
void RunControlPrivate::onToolPrepareFailed(const QString &msg)
@@ -712,7 +712,7 @@ void RunControlPrivate::onTargetStarted()
checkState(State::TargetStarting);
setState(State::ToolStarting);
debugMessage("Queue: Start tool runner");
QTimer::singleShot(0, toolRunner, &ToolRunner::start);
QTimer::singleShot(0, toolRunner, [this](){ toolRunner->start(); });
}
void RunControlPrivate::onTargetStartFailed(const QString &msg)
@@ -742,7 +742,7 @@ void RunControlPrivate::initiateStop()
checkState(State::Running);
setState(State::ToolStopping);
debugMessage("Queue: Stop tool runner");
QTimer::singleShot(0, toolRunner, &ToolRunner::stop);
QTimer::singleShot(0, toolRunner, [this](){ toolRunner->stop(); });
}
void RunControlPrivate::onToolStopped()
@@ -752,7 +752,7 @@ void RunControlPrivate::onToolStopped()
checkState(State::ToolStopping);
setState(State::TargetStopping);
debugMessage("Queue: Stop target runner");
QTimer::singleShot(0, targetRunner, &TargetRunner::stop);
QTimer::singleShot(0, targetRunner, [this](){ targetRunner->stop(); });
}
void RunControlPrivate::onToolStopFailed(const QString &msg)