From d60a67e800a95daff3134fa57ba423d77c4b96f6 Mon Sep 17 00:00:00 2001
From: Jarek Kobus <jaroslaw.kobus@qt.io>
Date: Mon, 23 Oct 2023 17:13:41 +0200
Subject: [PATCH] KillAppStep: Get rid of isDeploymentNecessary()

Make it a part of deployRecipe().

Change-Id: Ia52be36ccc2f387dce3d1c9e946179b9ef328717
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
 src/plugins/remotelinux/killappstep.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/plugins/remotelinux/killappstep.cpp b/src/plugins/remotelinux/killappstep.cpp
index b70e597fb84..3986ebe6b9b 100644
--- a/src/plugins/remotelinux/killappstep.cpp
+++ b/src/plugins/remotelinux/killappstep.cpp
@@ -38,7 +38,6 @@ public:
     }
 
 private:
-    bool isDeploymentNecessary() const final { return !m_remoteExecutable.isEmpty(); }
     GroupItem deployRecipe() final;
 
     FilePath m_remoteExecutable;
@@ -47,9 +46,14 @@ private:
 GroupItem KillAppStep::deployRecipe()
 {
     const auto setupHandler = [this](DeviceProcessKiller &killer) {
+        if (m_remoteExecutable.isEmpty()) {
+            addSkipDeploymentMessage();
+            return SetupResult::StopWithDone;
+        }
         killer.setProcessPath(m_remoteExecutable);
         addProgressMessage(Tr::tr("Trying to kill \"%1\" on remote device...")
                                   .arg(m_remoteExecutable.path()));
+        return SetupResult::Continue;
     };
     const auto doneHandler = [this](const DeviceProcessKiller &) {
         addProgressMessage(Tr::tr("Remote application killed."));