From d6543baa88057b2659ff28b674d10e34dfacc3dc Mon Sep 17 00:00:00 2001 From: Tobias Hunger Date: Tue, 10 Apr 2018 13:11:25 +0200 Subject: [PATCH] BuildStep: Make build steps more widely available Make the build steps apply to more buildsteplists. Task-number: QTCREATORBUG-19823 (and similar for other build steps) Change-Id: I09d3b4b6ad99453cb587303aa78b46e8a4f360bb Reviewed-by: Eike Ziller --- src/plugins/autotoolsprojectmanager/makestep.cpp | 3 --- src/plugins/genericprojectmanager/genericmakestep.cpp | 3 ++- src/plugins/ios/iosdsymbuildstep.cpp | 3 --- src/plugins/projectexplorer/processstep.cpp | 3 --- src/plugins/qmakeprojectmanager/makestep.cpp | 2 -- 5 files changed, 2 insertions(+), 12 deletions(-) diff --git a/src/plugins/autotoolsprojectmanager/makestep.cpp b/src/plugins/autotoolsprojectmanager/makestep.cpp index 596c2a025bf..222978d44af 100644 --- a/src/plugins/autotoolsprojectmanager/makestep.cpp +++ b/src/plugins/autotoolsprojectmanager/makestep.cpp @@ -65,9 +65,6 @@ MakeStepFactory::MakeStepFactory() registerStep(MAKE_STEP_ID); setDisplayName(tr("Make", "Display name for AutotoolsProjectManager::MakeStep id.")); setSupportedProjectType(AUTOTOOLS_PROJECT_ID); - setSupportedStepLists({ProjectExplorer::Constants::BUILDSTEPS_BUILD, - ProjectExplorer::Constants::BUILDSTEPS_CLEAN, - ProjectExplorer::Constants::BUILDSTEPS_DEPLOY}); } // MakeStep diff --git a/src/plugins/genericprojectmanager/genericmakestep.cpp b/src/plugins/genericprojectmanager/genericmakestep.cpp index 7bd16b83086..37951d0308d 100644 --- a/src/plugins/genericprojectmanager/genericmakestep.cpp +++ b/src/plugins/genericprojectmanager/genericmakestep.cpp @@ -318,7 +318,8 @@ GenericMakeAllStepFactory::GenericMakeAllStepFactory() setDisplayName(QCoreApplication::translate( "GenericProjectManager::Internal::GenericMakeStep", GENERIC_MS_DISPLAY_NAME)); setSupportedProjectType(Constants::GENERICPROJECT_ID); - setSupportedStepList(ProjectExplorer::Constants::BUILDSTEPS_BUILD); + setSupportedStepLists({ProjectExplorer::Constants::BUILDSTEPS_BUILD, + ProjectExplorer::Constants::BUILDSTEPS_DEPLOY}); } // diff --git a/src/plugins/ios/iosdsymbuildstep.cpp b/src/plugins/ios/iosdsymbuildstep.cpp index 95790185387..2cf4834bc66 100644 --- a/src/plugins/ios/iosdsymbuildstep.cpp +++ b/src/plugins/ios/iosdsymbuildstep.cpp @@ -328,9 +328,6 @@ void IosDsymBuildStepConfigWidget::resetDefaults() IosDsymBuildStepFactory::IosDsymBuildStepFactory() { registerStep(Constants::IOS_DSYM_BUILD_STEP_ID); - setSupportedStepLists({ProjectExplorer::Constants::BUILDSTEPS_CLEAN, - ProjectExplorer::Constants::BUILDSTEPS_BUILD, - ProjectExplorer::Constants::BUILDSTEPS_DEPLOY}); setSupportedDeviceTypes({Constants::IOS_DEVICE_TYPE, Constants::IOS_SIMULATOR_TYPE}); setDisplayName("dsymutil"); diff --git a/src/plugins/projectexplorer/processstep.cpp b/src/plugins/projectexplorer/processstep.cpp index afe2f9ada48..82805fa3eed 100644 --- a/src/plugins/projectexplorer/processstep.cpp +++ b/src/plugins/projectexplorer/processstep.cpp @@ -148,9 +148,6 @@ ProcessStepFactory::ProcessStepFactory() { registerStep(PROCESS_STEP_ID); setDisplayName(ProcessStep::tr("Custom Process Step", "item in combobox")); - setSupportedStepLists({ProjectExplorer::Constants::BUILDSTEPS_BUILD, - ProjectExplorer::Constants::BUILDSTEPS_CLEAN, - ProjectExplorer::Constants::BUILDSTEPS_DEPLOY}); } //******* diff --git a/src/plugins/qmakeprojectmanager/makestep.cpp b/src/plugins/qmakeprojectmanager/makestep.cpp index bbcf04fdc87..5195bba0a04 100644 --- a/src/plugins/qmakeprojectmanager/makestep.cpp +++ b/src/plugins/qmakeprojectmanager/makestep.cpp @@ -461,6 +461,4 @@ MakeStepFactory::MakeStepFactory() registerStep(MAKESTEP_BS_ID); setSupportedProjectType(Constants::QMAKEPROJECT_ID); setDisplayName(tr("Make")); - setSupportedStepLists({ProjectExplorer::Constants::BUILDSTEPS_BUILD, - ProjectExplorer::Constants::BUILDSTEPS_CLEAN}); }