feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Change BuildStepConfigWidget::summaryWidget()

Browse Source 
From a virtual function to a normal one backed by a real data member.

That's essentially what several re-implementations did, the other
ones used a fixed value instead.

Change-Id: I61e45f1d4f7f0f80fe2eb1f2729785f37e7bb803
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-10-15 17:52:15 +02:00
parent fb1c562c2e
commit d6c605d84c
35 changed files with 34 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/plugins/autotoolsprojectmanager/autoreconfstep.cpp
View File

@@ -169,11 +169,6 @@ AutoreconfStepConfigWidget::AutoreconfStepConfigWidget(AutoreconfStep *autorecon
this, &AutoreconfStepConfigWidget::updateDetails);
}
QString AutoreconfStepConfigWidget::summaryText() const
{
return m_summaryText;
}
void AutoreconfStepConfigWidget::updateDetails()
{
BuildConfiguration *bc = m_autoreconfStep->buildConfiguration();
@@ -185,6 +180,6 @@ void AutoreconfStepConfigWidget::updateDetails()
param.setWorkingDirectory(projectDir);
param.setCommand("autoreconf");
param.setArguments(m_autoreconfStep->additionalArguments());
m_summaryText = param.summary(displayName());
emit updateSummary();
setSummaryText(param.summary(displayName()));
}