feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Change BuildStepConfigWidget::summaryWidget()

Browse Source 
From a virtual function to a normal one backed by a real data member.

That's essentially what several re-implementations did, the other
ones used a fixed value instead.

Change-Id: I61e45f1d4f7f0f80fe2eb1f2729785f37e7bb803
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-10-15 17:52:15 +02:00
parent fb1c562c2e
commit d6c605d84c
35 changed files with 34 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakebuildstep.h
View File

@@ -120,7 +120,6 @@ class CMakeBuildStepConfigWidget : public ProjectExplorer::BuildStepConfigWidget
Q_OBJECT
public:
CMakeBuildStepConfigWidget(CMakeBuildStep *buildStep);
QString summaryText() const override;
private:
void itemChanged(QListWidgetItem*);
@@ -132,7 +131,6 @@ private:
CMakeBuildStep *m_buildStep;
QLineEdit *m_toolArguments;
QListWidget *m_buildTargetsList;
QString m_summaryText;
};
class CMakeBuildStepFactory : public ProjectExplorer::BuildStepFactory