feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Change BuildStepConfigWidget::summaryWidget()

Browse Source 
From a virtual function to a normal one backed by a real data member.

That's essentially what several re-implementations did, the other
ones used a fixed value instead.

Change-Id: I61e45f1d4f7f0f80fe2eb1f2729785f37e7bb803
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2018-10-15 17:52:15 +02:00
parent fb1c562c2e
commit d6c605d84c
35 changed files with 34 additions and 179 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/nim/project/nimcompilerbuildstepconfigwidget.cpp
View File

@@ -46,6 +46,7 @@ NimCompilerBuildStepConfigWidget::NimCompilerBuildStepConfigWidget(NimCompilerBu
m_ui->setupUi(this);
setDisplayName(tr(Constants::C_NIMCOMPILERBUILDSTEPWIDGET_DISPLAY));
setSummaryText(tr(Constants::C_NIMCOMPILERBUILDSTEPWIDGET_SUMMARY));
// Connect the project signals
auto project = static_cast<NimProject *>(m_buildStep->project());
@@ -69,11 +70,6 @@ NimCompilerBuildStepConfigWidget::NimCompilerBuildStepConfigWidget(NimCompilerBu
NimCompilerBuildStepConfigWidget::~NimCompilerBuildStepConfigWidget() = default;
QString NimCompilerBuildStepConfigWidget::summaryText() const
{
return tr(Constants::C_NIMCOMPILERBUILDSTEPWIDGET_SUMMARY);
}
void NimCompilerBuildStepConfigWidget::onTargetChanged(int index)
{
Q_UNUSED(index);