feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Remove BuildStepListWidget::init

Browse Source 
This kind of two-phase setup is not needed here.

Change-Id: Ie070c711ede1e4842f76f7d4ebf26809a3ad5236
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-10-31 11:11:39 +01:00
parent 953b018462
commit d6cfaa122f
4 changed files with 35 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/projectexplorer/buildsettingspropertiespage.cpp
View File

@@ -207,13 +207,11 @@ void BuildSettingsWidget::updateBuildSettings()
if (generalConfigWidget)
addSubWidget(generalConfigWidget);
auto buildStepsWidget = new BuildStepListWidget(this);
buildStepsWidget->init(m_buildConfiguration->stepList(Constants::BUILDSTEPS_BUILD));
addSubWidget(buildStepsWidget);
BuildStepList *buildSteps = m_buildConfiguration->stepList(Constants::BUILDSTEPS_BUILD);
addSubWidget(new BuildStepListWidget(buildSteps, this));
auto cleanStepsWidget = new BuildStepListWidget(this);
cleanStepsWidget->init(m_buildConfiguration->stepList(Constants::BUILDSTEPS_CLEAN));
addSubWidget(cleanStepsWidget);
BuildStepList *cleanSteps = m_buildConfiguration->stepList(Constants::BUILDSTEPS_CLEAN);
addSubWidget(new BuildStepListWidget(cleanSteps, this));
QList<NamedWidget *> subConfigWidgets = m_buildConfiguration->createSubConfigWidgets();
foreach (NamedWidget *subConfigWidget, subConfigWidgets)