forked from qt-creator/qt-creator
Utils: Rework CheckableMessageBox
Remove function overloads, thes are hard to read, to use and to extend. I'd even argue this should be a plain default ctor and a few setters + exec(), pretty much like Process::start() nowadays. Move "decider" magic into a structure that can be filled ad-hoc outside checkablemessagebox.cpp paving the ground for: ...removing aspect dependency from CheckableMessageBox, Instead, add a convenience function to BoolAspect. Arguably, the latter is not needed and could be done on the user side. Use pointers instead of mutable references for in-out parameter. Makes the "specialness" visible on the user side. Pass ICore::settings() centrally as done elsewhere to reduce line noise on the user side. Change-Id: Ibb366353d1ea35401723fd05ce05672617a0a8fd Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
@@ -2243,8 +2243,7 @@ bool wantRunTool(ToolMode toolMode, const QString &toolName)
|
||||
if (Utils::CheckableMessageBox::question(ICore::dialogParent(),
|
||||
title,
|
||||
message,
|
||||
ICore::settings(),
|
||||
"AnalyzerCorrectModeWarning")
|
||||
QString("AnalyzerCorrectModeWarning"))
|
||||
!= QMessageBox::Yes)
|
||||
return false;
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user