feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Tracing: Don't rebuild flame graph if there is nothing to see

Browse Source 
If the root size is 0, none of the nodes will be visible. Don't create
them in the first place.

Task-number: QTCREATORBUG-20772
Change-Id: I9595daece2d17fe8202b322ffafd361d6fa422fa
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
This commit is contained in:
Ulf Hermann
2018-07-12 14:27:26 +02:00
parent 3a4592609c
commit d7733bafe1
1 changed files with 7 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/libs/tracing/flamegraph.cpp
View File

@@ -185,11 +185,13 @@ void FlameGraph::rebuild()
return; return;
} }
if (m_root.isValid()) { if (m_model->data(m_root, m_sizeRole).toReal() > 0) {
QObject *parentObject = appendChild(this, this, qmlContext(this), m_root, 0, 1); if (m_root.isValid()) {
m_depth = buildNode(m_root, parentObject, 1, m_maximumDepth); QObject *parentObject = appendChild(this, this, qmlContext(this), m_root, 0, 1);
} else { m_depth = buildNode(m_root, parentObject, 1, m_maximumDepth);
m_depth = buildNode(m_root, this, 0, m_maximumDepth); } else {
m_depth = buildNode(m_root, this, 0, m_maximumDepth);
}
} }
emit depthChanged(m_depth); emit depthChanged(m_depth);