feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

VcsBase: Fix MSVC warning

Browse Source 
qhash.h(1138) : warning C4723: potential divide by 0

Change-Id: I368ec727d08d5e0bb333099a3536d97c65503e7d
Reviewed-by: André Hartmann <aha_1980@gmx.de>
This commit is contained in:
Orgad Shaneh
2022-05-15 09:27:53 +03:00
committed by Orgad Shaneh
parent b2e2421d2d
commit d78ebf69ba
1 changed files with 15 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/plugins/vcsbase/baseannotationhighlighter.cpp
View File

@@ -93,20 +93,21 @@ BaseAnnotationHighlighter::~BaseAnnotationHighlighter()
void BaseAnnotationHighlighter::setChangeNumbers(const ChangeNumbers &changeNumbers) void BaseAnnotationHighlighter::setChangeNumbers(const ChangeNumbers &changeNumbers)
{ {
d->m_changeNumberMap.clear(); d->m_changeNumberMap.clear();
if (!changeNumbers.isEmpty()) { const int changeNumberCount = changeNumbers.size();
// Assign a color gradient to annotation change numbers. Give if (changeNumberCount == 0)
// each change number a unique color. return;
const QList<QColor> colors = // Assign a color gradient to annotation change numbers. Give
TextEditor::SyntaxHighlighter::generateColors(changeNumbers.size(), d->m_background); // each change number a unique color.
int m = 0; const QList<QColor> colors =
const int cstep = colors.count() / changeNumbers.count(); TextEditor::SyntaxHighlighter::generateColors(changeNumberCount, d->m_background);
const ChangeNumbers::const_iterator cend = changeNumbers.constEnd(); int m = 0;
for (ChangeNumbers::const_iterator it = changeNumbers.constBegin(); it != cend; ++it) { const int cstep = colors.count() / changeNumberCount;
QTextCharFormat format; const ChangeNumbers::const_iterator cend = changeNumbers.constEnd();
format.setForeground(colors.at(m)); for (ChangeNumbers::const_iterator it = changeNumbers.constBegin(); it != cend; ++it) {
d->m_changeNumberMap.insert(*it, format); QTextCharFormat format;
m += cstep; format.setForeground(colors.at(m));
} d->m_changeNumberMap.insert(*it, format);
m += cstep;
} }
} }