feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Make enabled state updating part of runconfig updates

Browse Source 
RunConfiguration::update() is becoming a central place acting on
requests to act on interesting changes, triggering notifications
to "the outside" from there is natural.

Change-Id: I159cb548c159a607e2628a178362987fb37b59e3
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-12-04 09:19:50 +01:00
parent 6771a46928
commit d79c76eb11
4 changed files with 10 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
src/plugins/projectexplorer/runconfiguration.cpp
View File

@@ -156,11 +156,6 @@ void GlobalOrProjectAspect::resetProjectToGlobalSettings()
A RunConfiguration disables itself if the project has no parsing
data available. The disabledReason() method can be used to get a user-facing string
describing why the RunConfiguration considers itself unfit for use.
Override updateEnabledState() to change the enabled state handling. Override
disabledReasons() to provide better/more descriptions to the user.
Connect signals that may change enabled state of your RunConfiguration to updateEnabledState.
*/
static std::vector<RunConfiguration::AspectFactory> theAspectFactories;
@@ -169,12 +164,12 @@ RunConfiguration::RunConfiguration(Target *target, Core::Id id)
: ProjectConfiguration(target, id)
{
QTC_CHECK(target && target == this->target());
connect(target, &Target::parsingFinished, this, [this] { updateEnabledState(); });
connect(target, &Target::parsingFinished, this, &RunConfiguration::enabledChanged);
connect(target, &Target::addedRunConfiguration,
this, [this](const RunConfiguration *rc) {
if (rc == this)
updateEnabledState();
emit enabledChanged();
});
connect(this, &RunConfiguration::enabledChanged, this, [this] {
@@ -255,11 +250,6 @@ QWidget *RunConfiguration::createConfigurationWidget()
return detailsWidget;
}
void RunConfiguration::updateEnabledState()
{
emit enabledChanged();
}
void RunConfiguration::addAspectFactory(const AspectFactory &aspectFactory)
{
theAspectFactories.push_back(aspectFactory);
@@ -329,8 +319,10 @@ CommandLine RunConfiguration::commandLine() const
void RunConfiguration::update()
{
QTC_ASSERT(m_updater, return);
m_updater();
if (m_updater)
m_updater();
emit enabledChanged();
}
BuildTargetInfo RunConfiguration::buildTargetInfo() const